Title: [174406] trunk
- Revision
- 174406
- Author
- commit-qu...@webkit.org
- Date
- 2014-10-07 14:35:06 -0700 (Tue, 07 Oct 2014)
Log Message
[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=137499
Patch by Daniel Bates <daba...@apple.com> on 2014-10-07
Reviewed by Simon Fraser.
Tools:
Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
bit simulator builds of iOS WebKit.
* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._generate_all_test_configurations):
LayoutTests:
Add a new platform directory, called ios-simulator, and associated TestExpectation file.
For now, there is a single entry to skip all accessibility tests on iOS due to significant
API differences. We'll likely update TestExpectations as we rebaseline iOS Simulator
layout test results.
* platform/ios-simulator/TestExpectations: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (174405 => 174406)
--- trunk/LayoutTests/ChangeLog 2014-10-07 20:52:26 UTC (rev 174405)
+++ trunk/LayoutTests/ChangeLog 2014-10-07 21:35:06 UTC (rev 174406)
@@ -1,3 +1,17 @@
+2014-10-07 Daniel Bates <daba...@apple.com>
+
+ [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
+ https://bugs.webkit.org/show_bug.cgi?id=137499
+
+ Reviewed by Simon Fraser.
+
+ Add a new platform directory, called ios-simulator, and associated TestExpectation file.
+ For now, there is a single entry to skip all accessibility tests on iOS due to significant
+ API differences. We'll likely update TestExpectations as we rebaseline iOS Simulator
+ layout test results.
+
+ * platform/ios-simulator/TestExpectations: Added.
+
2014-10-07 Jer Noble <jer.no...@apple.com>
[Media] Expose AudioTracks in the "captions" menu.
Added: trunk/LayoutTests/platform/ios-simulator/TestExpectations (0 => 174406)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2014-10-07 21:35:06 UTC (rev 174406)
@@ -0,0 +1,7 @@
+# These are the layout test expectations for Apple's iOS port of WebKit.
+#
+# See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
+
+# Cannot enable AX tests because there are too many differences between what is available
+# through the iPhone AX API and the OS X AX API.
+accessibility
Modified: trunk/Tools/ChangeLog (174405 => 174406)
--- trunk/Tools/ChangeLog 2014-10-07 20:52:26 UTC (rev 174405)
+++ trunk/Tools/ChangeLog 2014-10-07 21:35:06 UTC (rev 174406)
@@ -1,3 +1,18 @@
+2014-10-07 Daniel Bates <daba...@apple.com>
+
+ [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
+ https://bugs.webkit.org/show_bug.cgi?id=137499
+
+ Reviewed by Simon Fraser.
+
+ Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
+ honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
+ should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
+ bit simulator builds of iOS WebKit.
+
+ * Scripts/webkitpy/port/ios.py:
+ (IOSSimulatorPort._generate_all_test_configurations):
+
2014-10-07 Youenn Fablet <youenn.fab...@crf.canon.fr>
[GTK] jhbuild modules should build xserver with the --without-dtrace option.
Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (174405 => 174406)
--- trunk/Tools/Scripts/webkitpy/port/ios.py 2014-10-07 20:52:26 UTC (rev 174405)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py 2014-10-07 21:35:06 UTC (rev 174406)
@@ -134,7 +134,8 @@
def _generate_all_test_configurations(self):
configurations = []
for build_type in self.ALL_BUILD_TYPES:
- configurations.append(TestConfiguration(version=self._version, architecture='x86', build_type=build_type))
+ for architecture in self.ARCHITECTURES:
+ configurations.append(TestConfiguration(version=self._version, architecture=architecture, build_type=build_type))
return configurations
def _driver_class(self):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
