Title: [174747] trunk/Source/WebCore
- Revision
- 174747
- Author
- cdu...@apple.com
- Date
- 2014-10-15 17:09:57 -0700 (Wed, 15 Oct 2014)
Log Message
[Mac] Fix inefficiencies in ResourceResponse::platformLazyInit(InitLevel) - Part 2
https://bugs.webkit.org/show_bug.cgi?id=137721
Reviewed by Darin Adler.
Follow-up patch to r174717 addressing review comments made after the patch landed:
- Use modern C++ loop
- Remove explicit calls to String(NSString*) constructor
No new tests, no new tests.
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174746 => 174747)
--- trunk/Source/WebCore/ChangeLog 2014-10-16 00:05:37 UTC (rev 174746)
+++ trunk/Source/WebCore/ChangeLog 2014-10-16 00:09:57 UTC (rev 174747)
@@ -1,5 +1,21 @@
2014-10-15 Chris Dumez <cdu...@apple.com>
+ [Mac] Fix inefficiencies in ResourceResponse::platformLazyInit(InitLevel) - Part 2
+ https://bugs.webkit.org/show_bug.cgi?id=137721
+
+ Reviewed by Darin Adler.
+
+ Follow-up patch to r174717 addressing review comments made after the patch landed:
+ - Use modern C++ loop
+ - Remove explicit calls to String(NSString*) constructor
+
+ No new tests, no new tests.
+
+ * platform/network/mac/ResourceResponseMac.mm:
+ (WebCore::ResourceResponse::platformLazyInit):
+
+2014-10-15 Chris Dumez <cdu...@apple.com>
+
Use is<>() / downcast<>() for InlineBox subclasses
https://bugs.webkit.org/show_bug.cgi?id=137749
Modified: trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm (174746 => 174747)
--- trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm 2014-10-16 00:05:37 UTC (rev 174746)
+++ trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm 2014-10-16 00:09:57 UTC (rev 174747)
@@ -138,9 +138,9 @@
if (initLevel < AllFields) {
NSDictionary *headers = [httpResponse allHeaderFields];
- for (unsigned i = 0; i < WTF_ARRAY_LENGTH(commonHeaderFields); ++i) {
- if (NSString* headerValue = [headers objectForKey:commonHeaderFields[i]])
- m_httpHeaderFields.set(String(commonHeaderFields[i]), headerValue);
+ for (NSString *name : commonHeaderFields) {
+ if (NSString* headerValue = [headers objectForKey:name])
+ m_httpHeaderFields.set(name, headerValue);
}
}
} else
@@ -161,7 +161,7 @@
NSDictionary *headers = [httpResponse allHeaderFields];
for (NSString *name in headers)
- m_httpHeaderFields.set(String(name), [headers objectForKey:name]);
+ m_httpHeaderFields.set(name, [headers objectForKey:name]);
[pool drain];
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
