Title: [174918] trunk/Source/WebCore
- Revision
- 174918
- Author
- msab...@apple.com
- Date
- 2014-10-20 18:21:03 -0700 (Mon, 20 Oct 2014)
Log Message
Make post checkin suggested changes to r174847
https://bugs.webkit.org/show_bug.cgi?id=137885
Reviewed by Mark Lam.
Eliminated the creation of a temporary Identifier when comparing propertyName to "open".
Made the suggested post checkin change to put the declaration of "entry" into the if.
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (174917 => 174918)
--- trunk/Source/WebCore/ChangeLog 2014-10-21 01:19:23 UTC (rev 174917)
+++ trunk/Source/WebCore/ChangeLog 2014-10-21 01:21:03 UTC (rev 174918)
@@ -1,3 +1,16 @@
+2014-10-20 Michael Saboff <msab...@apple.com>
+
+ Make post checkin suggested changes to r174847
+ https://bugs.webkit.org/show_bug.cgi?id=137885
+
+ Reviewed by Mark Lam.
+
+ Eliminated the creation of a temporary Identifier when comparing propertyName to "open".
+ Made the suggested post checkin change to put the declaration of "entry" into the if.
+
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::getOwnPropertySlot):
+
2014-10-20 Chris Dumez <cdu...@apple.com>
Use is<>() / downcast<>() for SpinButtonElement
Modified: trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp (174917 => 174918)
--- trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2014-10-21 01:19:23 UTC (rev 174917)
+++ trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2014-10-21 01:21:03 UTC (rev 174918)
@@ -62,7 +62,7 @@
JSHTMLDocument* thisObject = jsCast<JSHTMLDocument*>(object);
ASSERT_GC_OBJECT_INHERITS(thisObject, info());
- if (propertyName == Identifier(exec, "open")) {
+ if (equal(propertyName.publicName(), "open")) {
slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, nonCachingStaticFunctionGetter<jsHTMLDocumentPrototypeFunctionOpen, 2>);
return true;
}
@@ -72,8 +72,7 @@
return true;
}
- const HashTableValue* entry = JSHTMLDocument::info()->staticPropHashTable->entry(propertyName);
- if (entry) {
+ if (const HashTableValue* entry = JSHTMLDocument::info()->staticPropHashTable->entry(propertyName)) {
slot.setCacheableCustom(thisObject, entry->attributes(), entry->propertyGetter());
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
