Title: [175801] trunk/Tools
Revision
175801
Author
commit-qu...@webkit.org
Date
2014-11-09 23:59:26 -0800 (Sun, 09 Nov 2014)

Log Message

Fix the exception fuzz helper to generate targets in the correct range
https://bugs.webkit.org/show_bug.cgi?id=138544

Patch by Akos Kiss <ak...@inf.u-szeged.hu> on 2014-11-10
Reviewed by Filip Pizlo.

Currently, the script generates exception fuzz targets in the range of
0..($checkCount-1). However, target 0 is never hit, while target 1 is
always outside of the outermost try block of the tests, which therefore
prints unexpected output and results in false failures when fired at.
Additionally, target $checkCount is never generated.

This patch fixes the script to generate targets in the range of
2..$checkCount.

* Scripts/jsc-stress-test-helpers/js-exception-fuzz:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (175800 => 175801)


--- trunk/Tools/ChangeLog	2014-11-10 06:52:30 UTC (rev 175800)
+++ trunk/Tools/ChangeLog	2014-11-10 07:59:26 UTC (rev 175801)
@@ -1,3 +1,21 @@
+2014-11-10  Akos Kiss  <ak...@inf.u-szeged.hu>
+
+        Fix the exception fuzz helper to generate targets in the correct range
+        https://bugs.webkit.org/show_bug.cgi?id=138544
+
+        Reviewed by Filip Pizlo.
+
+        Currently, the script generates exception fuzz targets in the range of
+        0..($checkCount-1). However, target 0 is never hit, while target 1 is
+        always outside of the outermost try block of the tests, which therefore
+        prints unexpected output and results in false failures when fired at.
+        Additionally, target $checkCount is never generated.
+
+        This patch fixes the script to generate targets in the range of
+        2..$checkCount.
+
+        * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
+
 2014-11-09  Csaba Osztrogonác  <o...@webkit.org>
 
         make-passwords-json.py should generarate everything needed for testing

Modified: trunk/Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz (175800 => 175801)


--- trunk/Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz	2014-11-10 06:52:30 UTC (rev 175800)
+++ trunk/Tools/Scripts/jsc-stress-test-helpers/js-exception-fuzz	2014-11-10 07:59:26 UTC (rev 175801)
@@ -100,7 +100,7 @@
 srand($seed);
 
 for (my $iteration = 0; $iteration < $repeat; ++$iteration) {
-    my $target = int(rand() * $checkCount);
+    my $target = int(rand() * ($checkCount - 1)) + 2;
     if ($verbose) {
         print "iteration($iteration) target($target): Running.\n";
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to