Title: [176119] trunk/Source/WebKit2
Revision
176119
Author
carlo...@webkit.org
Date
2014-11-14 00:49:55 -0800 (Fri, 14 Nov 2014)

Log Message

[SOUP] Encode/Decode allowCookies in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=138730

Reviewed by Sergio Villar Senin.

We are not sending this information to the network process, making
cookies always available. Fixes
http/tests/xmlhttprequest/cross-origin-no-authorization.html when
network process is enabled.

* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (176118 => 176119)


--- trunk/Source/WebKit2/ChangeLog	2014-11-14 08:43:05 UTC (rev 176118)
+++ trunk/Source/WebKit2/ChangeLog	2014-11-14 08:49:55 UTC (rev 176119)
@@ -1,3 +1,19 @@
+2014-11-14  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [SOUP] Encode/Decode allowCookies in ResourceRequest
+        https://bugs.webkit.org/show_bug.cgi?id=138730
+
+        Reviewed by Sergio Villar Senin.
+
+        We are not sending this information to the network process, making
+        cookies always available. Fixes
+        http/tests/xmlhttprequest/cross-origin-no-authorization.html when
+        network process is enabled.
+
+        * Shared/soup/WebCoreArgumentCodersSoup.cpp:
+        (IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
+        (IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
+
 2014-11-14  Zan Dobersek  <zdober...@igalia.com>
 
         Unreviewed build fix for the GTK+ port using Clang.

Modified: trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp (176118 => 176119)


--- trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp	2014-11-14 08:43:05 UTC (rev 176118)
+++ trunk/Source/WebKit2/Shared/soup/WebCoreArgumentCodersSoup.cpp	2014-11-14 08:49:55 UTC (rev 176119)
@@ -55,6 +55,7 @@
         encoder << httpBody->flattenToString();
 
     encoder << resourceRequest.firstPartyForCookies().string();
+    encoder << resourceRequest.allowCookies();
     encoder.encodeEnum(resourceRequest.priority());
 
     encoder << static_cast<uint32_t>(resourceRequest.soupMessageFlags());
@@ -98,6 +99,11 @@
         return false;
     resourceRequest.setFirstPartyForCookies(URL(URL(), firstPartyForCookies));
 
+    bool allowCookies;
+    if (!decoder.decode(allowCookies))
+        return false;
+    resourceRequest.setAllowCookies(allowCookies);
+
     ResourceLoadPriority priority;
     if (!decoder.decodeEnum(priority))
         return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to