Title: [176768] trunk
- Revision
- 176768
- Author
- mmaxfi...@apple.com
- Date
- 2014-12-03 17:30:07 -0800 (Wed, 03 Dec 2014)
Log Message
List markers in RTL languages do not draw the first character.
https://bugs.webkit.org/show_bug.cgi?id=139244
Reviewed by Simon Fraser.
Source/WebCore:
Off-by-one error when reversing the string (from LTR to RTL)
Test: fast/lists/rtl-marker.html
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
LayoutTests:
* fast/lists/rtl-marker-expected.html: Added.
* fast/lists/rtl-marker.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (176767 => 176768)
--- trunk/LayoutTests/ChangeLog 2014-12-04 01:08:10 UTC (rev 176767)
+++ trunk/LayoutTests/ChangeLog 2014-12-04 01:30:07 UTC (rev 176768)
@@ -1,3 +1,13 @@
+2014-12-03 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ List markers in RTL languages do not draw the first character.
+ https://bugs.webkit.org/show_bug.cgi?id=139244
+
+ Reviewed by Simon Fraser.
+
+ * fast/lists/rtl-marker-expected.html: Added.
+ * fast/lists/rtl-marker.html: Added.
+
2014-12-03 Chris Dumez <cdu...@apple.com>
Unreviewed gardening.
Added: trunk/LayoutTests/fast/lists/rtl-marker-expected.html (0 => 176768)
--- trunk/LayoutTests/fast/lists/rtl-marker-expected.html (rev 0)
+++ trunk/LayoutTests/fast/lists/rtl-marker-expected.html 2014-12-04 01:30:07 UTC (rev 176768)
@@ -0,0 +1,5 @@
+<!DOCTYPE html>
+This test makes sure that lists whose markers are in RTL languages are correctly rendered.
+<ol style="line-height: 50px; list-style-type: hebrew; list-style-type: none;" start="97">
+<li>צז.</li>
+</ol>
Added: trunk/LayoutTests/fast/lists/rtl-marker.html (0 => 176768)
--- trunk/LayoutTests/fast/lists/rtl-marker.html (rev 0)
+++ trunk/LayoutTests/fast/lists/rtl-marker.html 2014-12-04 01:30:07 UTC (rev 176768)
@@ -0,0 +1,5 @@
+<!DOCTYPE html>
+This test makes sure that lists whose markers are in RTL languages are correctly rendered.
+<ol style="line-height: 50px; list-style-type: hebrew; list-style-position: inside;" start="97">
+<li></li>
+</ol>
Modified: trunk/Source/WebCore/ChangeLog (176767 => 176768)
--- trunk/Source/WebCore/ChangeLog 2014-12-04 01:08:10 UTC (rev 176767)
+++ trunk/Source/WebCore/ChangeLog 2014-12-04 01:30:07 UTC (rev 176768)
@@ -1,3 +1,17 @@
+2014-12-03 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ List markers in RTL languages do not draw the first character.
+ https://bugs.webkit.org/show_bug.cgi?id=139244
+
+ Reviewed by Simon Fraser.
+
+ Off-by-one error when reversing the string (from LTR to RTL)
+
+ Test: fast/lists/rtl-marker.html
+
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+
2014-12-03 Beth Dakin <bda...@apple.com>
<input> elements get whitespace action menu instead of editable text menu
Modified: trunk/Source/WebCore/rendering/RenderListMarker.cpp (176767 => 176768)
--- trunk/Source/WebCore/rendering/RenderListMarker.cpp 2014-12-04 01:08:10 UTC (rev 176767)
+++ trunk/Source/WebCore/rendering/RenderListMarker.cpp 2014-12-04 01:30:07 UTC (rev 176768)
@@ -1342,7 +1342,7 @@
StringBuilder buffer;
buffer.reserveCapacity(length);
for (unsigned i = 0; i < length; ++i)
- buffer.append(m_text[length - i]);
+ buffer.append(m_text[length - i - 1]);
reversedText = buffer.toString();
textRun.setText(StringView(reversedText));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
