Title: [179879] trunk/Source/WebInspectorUI
- Revision
- 179879
- Author
- commit-qu...@webkit.org
- Date
- 2015-02-10 13:41:53 -0800 (Tue, 10 Feb 2015)
Log Message
Web Inspector: CSS Pretty Printing: still fails fails to put space between rgb(...) and numbers in minified gradients
https://bugs.webkit.org/show_bug.cgi?id=141411
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-02-10
Reviewed by Timothy Hatcher.
* Tools/PrettyPrinting/CodeMirrorFormatters.js:
* UserInterface/Views/CodeMirrorFormatters.js:
Token actually was "number m-css" so we should check token strings
more robustly, like elsewhere in the formatters.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (179878 => 179879)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-02-10 21:39:41 UTC (rev 179878)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-02-10 21:41:53 UTC (rev 179879)
@@ -1,3 +1,15 @@
+2015-02-10 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: CSS Pretty Printing: still fails fails to put space between rgb(...) and numbers in minified gradients
+ https://bugs.webkit.org/show_bug.cgi?id=141411
+
+ Reviewed by Timothy Hatcher.
+
+ * Tools/PrettyPrinting/CodeMirrorFormatters.js:
+ * UserInterface/Views/CodeMirrorFormatters.js:
+ Token actually was "number m-css" so we should check token strings
+ more robustly, like elsewhere in the formatters.
+
2015-02-09 Brian J. Burg <b...@cs.washington.edu>
Web Inspector: Uncaught exception when reporting wrong backend command call signature
Modified: trunk/Source/WebInspectorUI/Tools/PrettyPrinting/CodeMirrorFormatters.js (179878 => 179879)
--- trunk/Source/WebInspectorUI/Tools/PrettyPrinting/CodeMirrorFormatters.js 2015-02-10 21:39:41 UTC (rev 179878)
+++ trunk/Source/WebInspectorUI/Tools/PrettyPrinting/CodeMirrorFormatters.js 2015-02-10 21:41:53 UTC (rev 179879)
@@ -323,7 +323,7 @@
if (lastContent === ":") // Space in "prop: value" but not in a selectors "a:link" or "div::after" or media queries "(max-device-width:480px)".
return state.state === "prop";
if (lastContent === ")" && (content !== ")" && content !== ",")) {
- if (token === "number") // linear-gradient(rgb(...)0%,rgb(...)100%)
+ if (/\bnumber\b/.test(token)) // linear-gradient(rgb(...)0%,rgb(...)100%)
return true;
if (state.state === "prop") // -webkit-transform:rotate(...)translate(...);
return true;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js (179878 => 179879)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js 2015-02-10 21:39:41 UTC (rev 179878)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js 2015-02-10 21:41:53 UTC (rev 179879)
@@ -323,7 +323,7 @@
if (lastContent === ":") // Space in "prop: value" but not in a selectors "a:link" or "div::after" or media queries "(max-device-width:480px)".
return state.state === "prop";
if (lastContent === ")" && (content !== ")" && content !== ",")) {
- if (token === "number") // linear-gradient(rgb(...)0%,rgb(...)100%)
+ if (/\bnumber\b/.test(token)) // linear-gradient(rgb(...)0%,rgb(...)100%)
return true;
if (state.state === "prop") // -webkit-transform:rotate(...)translate(...);
return true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
