Title: [180611] trunk/Tools
- Revision
- 180611
- Author
- a...@apple.com
- Date
- 2015-02-24 20:32:49 -0800 (Tue, 24 Feb 2015)
Log Message
Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
https://bugs.webkit.org/show_bug.cgi?id=141889
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (180610 => 180611)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-02-25 04:28:52 UTC (rev 180610)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-02-25 04:32:49 UTC (rev 180611)
@@ -464,7 +464,9 @@
console.assert(data.num_flaky === this.layoutTestResults.flakyTests.length);
this.layoutTestResults.testsWithMissingResults = collectResults(data.tests, function(info) { return info["report"] === "MISSING" });
- console.assert(data.num_missing === this.layoutTestResults.testsWithMissingResults.length);
+ // data.num_missing is not always equal to the size of testsWithMissingResults array,
+ // because buildbot counts regressions that had missing pixel results on retry (e.g. "TEXT MISSING").
+ console.assert(data.num_missing >= this.layoutTestResults.testsWithMissingResults.length);
callback();
}.bind(this),
Modified: trunk/Tools/ChangeLog (180610 => 180611)
--- trunk/Tools/ChangeLog 2015-02-25 04:28:52 UTC (rev 180610)
+++ trunk/Tools/ChangeLog 2015-02-25 04:32:49 UTC (rev 180611)
@@ -1,3 +1,12 @@
+2015-02-24 Alexey Proskuryakov <a...@apple.com>
+
+ Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
+ https://bugs.webkit.org/show_bug.cgi?id=141889
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+
2015-02-24 Yusuke Suzuki <utatane....@gmail.com>
REGRESSION(r179429): Can't type comments in Facebook
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
