Title: [180714] trunk/Source/WebInspectorUI
- Revision
- 180714
- Author
- joep...@webkit.org
- Date
- 2015-02-26 17:15:17 -0800 (Thu, 26 Feb 2015)
Log Message
Web Inspector: Set/Map appear as lossless when they have lossy entries
https://bugs.webkit.org/show_bug.cgi?id=142050
Reviewed by Timothy Hatcher.
* UserInterface/Views/ObjectPreviewView.js:
(WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
Take into account the lossless states of entry keys and values.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (180713 => 180714)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-02-27 01:15:15 UTC (rev 180713)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-02-27 01:15:17 UTC (rev 180714)
@@ -1,5 +1,16 @@
2015-02-26 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Set/Map appear as lossless when they have lossy entries
+ https://bugs.webkit.org/show_bug.cgi?id=142050
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ObjectPreviewView.js:
+ (WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
+ Take into account the lossless states of entry keys and values.
+
+2015-02-26 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: New ObjectTree UI for Arrays / Maps / Sets
https://bugs.webkit.org/show_bug.cgi?id=142037
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js (180713 => 180714)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js 2015-02-27 01:15:15 UTC (rev 180713)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectPreviewView.js 2015-02-27 01:15:17 UTC (rev 180714)
@@ -145,13 +145,17 @@
if (i > 0)
element.appendChild(document.createTextNode(", "));
+ var keyPreviewLossless = true;
var entry = preview.collectionEntryPreviews[i];
if (entry.keyPreview) {
- this._appendPreview(element, entry.keyPreview);
+ keyPreviewLossless = this._appendPreview(element, entry.keyPreview);
element.appendChild(document.createTextNode(" => "));
}
- this._appendPreview(element, entry.valuePreview);
+ var valuePreviewLossless = this._appendPreview(element, entry.valuePreview);
+
+ if (!keyPreviewLossless || !valuePreviewLossless)
+ lossless = false;
}
if (preview.overflow)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
