Title: [180721] trunk/Source/WebInspectorUI
- Revision
- 180721
- Author
- commit-qu...@webkit.org
- Date
- 2015-02-26 20:08:24 -0800 (Thu, 26 Feb 2015)
Log Message
Web Inspector: Clear Log on Reload clears some logs that were after reload
https://bugs.webkit.org/show_bug.cgi?id=142070
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-02-26
Reviewed by Timothy Hatcher.
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._sessionStarted):
We can bail after calling clearLog, since that will already start
a new session for us.
(WebInspector.LogContentView.prototype._clearLog):
Don't trigger a backend clear messages, since that will cause us to
clear messages received between the request and response.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (180720 => 180721)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-02-27 02:07:22 UTC (rev 180720)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-02-27 04:08:24 UTC (rev 180721)
@@ -1,5 +1,21 @@
2015-02-26 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Clear Log on Reload clears some logs that were after reload
+ https://bugs.webkit.org/show_bug.cgi?id=142070
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/LogContentView.js:
+ (WebInspector.LogContentView.prototype._sessionStarted):
+ We can bail after calling clearLog, since that will already start
+ a new session for us.
+
+ (WebInspector.LogContentView.prototype._clearLog):
+ Don't trigger a backend clear messages, since that will cause us to
+ clear messages received between the request and response.
+
+2015-02-26 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Save Console Evaluations into Command Line variables $1-$99 ($n)
https://bugs.webkit.org/show_bug.cgi?id=142061
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (180720 => 180721)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2015-02-27 02:07:22 UTC (rev 180720)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2015-02-27 04:08:24 UTC (rev 180721)
@@ -303,8 +303,10 @@
_sessionStarted: function(event)
{
- if (this._clearLogOnReloadSetting.value)
+ if (this._clearLogOnReloadSetting.value) {
this._clearLog();
+ return;
+ }
this._logViewController.startNewSession();
},
@@ -638,7 +640,9 @@
_clearLog: function()
{
+ this._ignoreDidClearMessages = true;
this._logViewController.clear();
+ this._ignoreDidClearMessages = false;
},
_scopeBarSelectionDidChange: function(event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
