Title: [181558] trunk/Source/WTF
- Revision
- 181558
- Author
- benja...@webkit.org
- Date
- 2015-03-16 09:32:27 -0700 (Mon, 16 Mar 2015)
Log Message
Fix StringView after r181525
Unreviewed.
Fix 2 silly mistakes I made in r181525.
* wtf/text/StringView.cpp:
(WTF::StringView::startsWith):
(WTF::StringView::startsWithIgnoringASCIICase):
(WTF::StringView::endsWith):
(WTF::StringView::endsWithIgnoringASCIICase):
The implementation was inside the #ifdef.
* wtf/text/StringView.h:
The symbols were not exported.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (181557 => 181558)
--- trunk/Source/WTF/ChangeLog 2015-03-16 16:32:14 UTC (rev 181557)
+++ trunk/Source/WTF/ChangeLog 2015-03-16 16:32:27 UTC (rev 181558)
@@ -1,3 +1,20 @@
+2015-03-16 Benjamin Poulain <benja...@webkit.org>
+
+ Fix StringView after r181525
+ Unreviewed.
+
+ Fix 2 silly mistakes I made in r181525.
+
+ * wtf/text/StringView.cpp:
+ (WTF::StringView::startsWith):
+ (WTF::StringView::startsWithIgnoringASCIICase):
+ (WTF::StringView::endsWith):
+ (WTF::StringView::endsWithIgnoringASCIICase):
+ The implementation was inside the #ifdef.
+
+ * wtf/text/StringView.h:
+ The symbols were not exported.
+
2015-03-16 Max Stepin <maxste...@gmail.com>
Add APNG support
Modified: trunk/Source/WTF/wtf/text/StringView.cpp (181557 => 181558)
--- trunk/Source/WTF/wtf/text/StringView.cpp 2015-03-16 16:32:14 UTC (rev 181557)
+++ trunk/Source/WTF/wtf/text/StringView.cpp 2015-03-16 16:32:27 UTC (rev 181558)
@@ -31,10 +31,30 @@
#include <wtf/HashMap.h>
#include <wtf/NeverDestroyed.h>
+namespace WTF {
+
+bool StringView::startsWith(const StringView& prefix) const
+{
+ return ::WTF::startsWith(*this, prefix);
+}
+
+bool StringView::startsWithIgnoringASCIICase(const StringView& prefix) const
+{
+ return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
+}
+
+bool StringView::endsWith(const StringView& prefix) const
+{
+ return ::WTF::startsWith(*this, prefix);
+}
+
+bool StringView::endsWithIgnoringASCIICase(const StringView& prefix) const
+{
+ return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
+}
+
#if CHECK_STRINGVIEW_LIFETIME
-namespace WTF {
-
// Manage reference count manually so UnderlyingString does not need to be defined in the header.
struct StringView::UnderlyingString {
@@ -118,26 +138,6 @@
adoptUnderlyingString(underlyingString);
}
-bool StringView::startsWith(const StringView& prefix) const
-{
- return ::WTF::startsWith(*this, prefix);
-}
+#endif // CHECK_STRINGVIEW_LIFETIME
-bool StringView::startsWithIgnoringASCIICase(const StringView& prefix) const
-{
- return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
-}
-
-bool StringView::endsWith(const StringView& prefix) const
-{
- return ::WTF::startsWith(*this, prefix);
-}
-
-bool StringView::endsWithIgnoringASCIICase(const StringView& prefix) const
-{
- return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
-}
-
-}
-
-#endif
+} // namespace WTF
Modified: trunk/Source/WTF/wtf/text/StringView.h (181557 => 181558)
--- trunk/Source/WTF/wtf/text/StringView.h 2015-03-16 16:32:14 UTC (rev 181557)
+++ trunk/Source/WTF/wtf/text/StringView.h 2015-03-16 16:32:27 UTC (rev 181558)
@@ -106,11 +106,11 @@
size_t find(UChar, unsigned start = 0) const;
bool contains(UChar) const;
- bool startsWith(const StringView&) const;
- bool startsWithIgnoringASCIICase(const StringView&) const;
+ WTF_EXPORT_STRING_API bool startsWith(const StringView&) const;
+ WTF_EXPORT_STRING_API bool startsWithIgnoringASCIICase(const StringView&) const;
- bool endsWith(const StringView&) const;
- bool endsWithIgnoringASCIICase(const StringView&) const;
+ WTF_EXPORT_STRING_API bool endsWith(const StringView&) const;
+ WTF_EXPORT_STRING_API bool endsWithIgnoringASCIICase(const StringView&) const;
int toInt(bool& isValid) const;
float toFloat(bool& isValid) const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
