Title: [181768] trunk/Source/WebInspectorUI
- Revision
- 181768
- Author
- jonowe...@apple.com
- Date
- 2015-03-19 16:52:13 -0700 (Thu, 19 Mar 2015)
Log Message
Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause
https://bugs.webkit.org/show_bug.cgi?id=142847
Reviewed by Timothy Hatcher.
Add a `paused` class on the debugger sidebar panel. Use that class to adjust the sidebar styles so that, when
the debugger is not paused: there is no header for the scripts section, there is no border beneath the scripts
section, and the scripts section cannot be collapsed (which could be done while the debugger is paused). The
header has changed to say "Scripts" instead of "Breakpoints" when it is showing.
* UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger .details-section.scripts):
(.sidebar > .panel.navigation.debugger .details-section.scripts .header):
(.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header):
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content):
Adjust styles to hide header and border.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
Add a `paused` class to the debugger sidebar when it is paused.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (181767 => 181768)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-03-19 23:33:17 UTC (rev 181767)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-03-19 23:52:13 UTC (rev 181768)
@@ -1,5 +1,32 @@
2015-03-19 Jono Wells <jonowe...@apple.com>
+ Web Inspector: Debugger sidebar header should say "Scripts" instead of "Breakpoints", appear only on pause
+ https://bugs.webkit.org/show_bug.cgi?id=142847
+
+ Reviewed by Timothy Hatcher.
+
+ Add a `paused` class on the debugger sidebar panel. Use that class to adjust the sidebar styles so that, when
+ the debugger is not paused: there is no header for the scripts section, there is no border beneath the scripts
+ section, and the scripts section cannot be collapsed (which could be done while the debugger is paused). The
+ header has changed to say "Scripts" instead of "Breakpoints" when it is showing.
+
+ * UserInterface/Views/DebuggerSidebarPanel.css:
+ (.sidebar > .panel.navigation.debugger .details-section.scripts):
+ (.sidebar > .panel.navigation.debugger .details-section.scripts .header):
+ (.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
+ (.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
+ (.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header):
+ (.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content):
+ Adjust styles to hide header and border.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WebInspector.DebuggerSidebarPanel):
+ (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
+ (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
+ Add a `paused` class to the debugger sidebar when it is paused.
+
+2015-03-19 Jono Wells <jonowe...@apple.com>
+
Web Inspector: FilterBar for debugger sidebar hides breakpoints for displayed resources
https://bugs.webkit.org/show_bug.cgi?id=142777
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css (181767 => 181768)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css 2015-03-19 23:33:17 UTC (rev 181767)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css 2015-03-19 23:52:13 UTC (rev 181768)
@@ -41,3 +41,27 @@
.sidebar > .panel.navigation.debugger .details-section {
font-size: 11px;
}
+
+.sidebar > .panel.navigation.debugger .details-section.scripts {
+ border-bottom: none;
+}
+
+.sidebar > .panel.navigation.debugger .details-section.scripts .header {
+ display: none;
+}
+
+.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content {
+ display: block;
+}
+
+.sidebar > .panel.navigation.debugger.paused .details-section.scripts {
+ border-bottom: 1px solid rgb(179, 179, 179);
+}
+
+.sidebar > .panel.navigation.debugger.paused .details-section.scripts .header {
+ display: block;
+}
+
+.sidebar > .panel.navigation.debugger.paused .details-section.scripts.collapsed > .content {
+ display: none;
+}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (181767 => 181768)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2015-03-19 23:33:17 UTC (rev 181767)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2015-03-19 23:52:13 UTC (rev 181768)
@@ -124,7 +124,7 @@
breakpointsRow.element.appendChild(this._breakpointsContentTreeOutline.element);
var breakpointsGroup = new WebInspector.DetailsSectionGroup([breakpointsRow]);
- var breakpointsSection = new WebInspector.DetailsSection("breakpoints", WebInspector.UIString("Breakpoints"), [breakpointsGroup]);
+ var breakpointsSection = new WebInspector.DetailsSection("scripts", WebInspector.UIString("Scripts"), [breakpointsGroup]);
this.contentElement.appendChild(breakpointsSection.element);
this._callStackContentTreeOutline = this.createContentTreeOutline(true);
@@ -148,6 +148,7 @@
};
WebInspector.DebuggerSidebarPanel.OffsetSectionsStyleClassName = "offset-sections";
+WebInspector.DebuggerSidebarPanel.DebuggerPausedStyleClassName = "paused";
WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName = "breakpoint-exception-icon";
WebInspector.DebuggerSidebarPanel.PausedBreakpointIconStyleClassName = "breakpoint-paused-icon";
WebInspector.DebuggerSidebarPanel.GlobalIconStyleClassName = "global-breakpoints-icon";
@@ -253,6 +254,8 @@
this._debuggerPauseResumeButtonItem.toggled = true;
this._debuggerStepOverButtonItem.enabled = true;
this._debuggerStepIntoButtonItem.enabled = true;
+
+ this.element.classList.add(WebInspector.DebuggerSidebarPanel.DebuggerPausedStyleClassName);
},
_debuggerDidResume: function(event)
@@ -265,6 +268,8 @@
this._debuggerStepOverButtonItem.enabled = false;
this._debuggerStepIntoButtonItem.enabled = false;
this._debuggerStepOutButtonItem.enabled = false;
+
+ this.element.classList.remove(WebInspector.DebuggerSidebarPanel.DebuggerPausedStyleClassName);
},
_breakpointsEnabledDidChange: function(event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
