Title: [181989] trunk/Source/WebCore
Revision
181989
Author
d...@apple.com
Date
2015-03-25 18:05:20 -0700 (Wed, 25 Mar 2015)

Log Message

CSS blend modes do not parse when in the shadow tree
https://bugs.webkit.org/show_bug.cgi?id=143067
<rdar://problem/20302662>

Reviewed by Anders Carlson.

The media controls style sheets are injected as UA stylesheets
when we come across a <video> or <audio> element. These stylesheets
have a different parsing context than the document stylesheets -
one that uses the default constructor, which initializes some
features like cssCompositingEnabled to false without checking
the runtime state.

The easy fix is to use the global state to initialize the context.

Unfortunately we can't test this since it only occurs in the shadow
tree.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext): Check the state
of RuntimeEnabledFeatures to initialize CSS Regions and
CSS Compositing (Blending).

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (181988 => 181989)


--- trunk/Source/WebCore/ChangeLog	2015-03-26 00:53:52 UTC (rev 181988)
+++ trunk/Source/WebCore/ChangeLog	2015-03-26 01:05:20 UTC (rev 181989)
@@ -1,3 +1,28 @@
+2015-03-25  Dean Jackson  <d...@apple.com>
+
+        CSS blend modes do not parse when in the shadow tree
+        https://bugs.webkit.org/show_bug.cgi?id=143067
+        <rdar://problem/20302662>
+
+        Reviewed by Anders Carlson.
+
+        The media controls style sheets are injected as UA stylesheets
+        when we come across a <video> or <audio> element. These stylesheets
+        have a different parsing context than the document stylesheets -
+        one that uses the default constructor, which initializes some
+        features like cssCompositingEnabled to false without checking
+        the runtime state.
+
+        The easy fix is to use the global state to initialize the context.
+
+        Unfortunately we can't test this since it only occurs in the shadow
+        tree.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParserContext::CSSParserContext): Check the state
+        of RuntimeEnabledFeatures to initialize CSS Regions and
+        CSS Compositing (Blending).
+
 2015-03-25  Chris Fleizach  <cfleiz...@apple.com>
 
         AX: table cells that use display:block render the table inaccessible to VoiceOver

Modified: trunk/Source/WebCore/css/CSSParser.cpp (181988 => 181989)


--- trunk/Source/WebCore/css/CSSParser.cpp	2015-03-26 00:53:52 UTC (rev 181988)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2015-03-26 01:05:20 UTC (rev 181989)
@@ -257,8 +257,8 @@
     : baseURL(baseURL)
     , mode(mode)
     , isHTMLDocument(false)
-    , isCSSRegionsEnabled(false)
-    , isCSSCompositingEnabled(false)
+    , isCSSRegionsEnabled(RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled())
+    , isCSSCompositingEnabled(RuntimeEnabledFeatures::sharedFeatures().cssCompositingEnabled())
     , needsSiteSpecificQuirks(false)
     , enforcesCSSMIMETypeInNoQuirksMode(true)
     , useLegacyBackgroundSizeShorthandBehavior(false)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to