Title: [182094] trunk/Source/WebInspectorUI
Revision
182094
Author
commit-qu...@webkit.org
Date
2015-03-27 17:56:03 -0700 (Fri, 27 Mar 2015)

Log Message

Web Inspector: Uncaught Exceptions evaluating code while paused
https://bugs.webkit.org/show_bug.cgi?id=143163

Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-03-27
Reviewed by Timothy Hatcher.

* UserInterface/Models/CallFrame.js:
(WebInspector.CallFrame.prototype.collectScopeChainVariableNames):
We define a property named "valueForCaseInsensitiveKey" on Object.prototype
that is readonly. So we should avoid Object.prototype when building our
result list. This should probably move to a Map object eventually.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182093 => 182094)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-28 00:54:31 UTC (rev 182093)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-28 00:56:03 UTC (rev 182094)
@@ -1,5 +1,18 @@
 2015-03-27  Joseph Pecoraro  <pecor...@apple.com>
 
+        Web Inspector: Uncaught Exceptions evaluating code while paused
+        https://bugs.webkit.org/show_bug.cgi?id=143163
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/CallFrame.js:
+        (WebInspector.CallFrame.prototype.collectScopeChainVariableNames):
+        We define a property named "valueForCaseInsensitiveKey" on Object.prototype
+        that is readonly. So we should avoid Object.prototype when building our
+        result list. This should probably move to a Map object eventually.
+
+2015-03-27  Joseph Pecoraro  <pecor...@apple.com>
+
         Web Inspector: Remove unused testing properties
         https://bugs.webkit.org/show_bug.cgi?id=143156
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CallFrame.js (182093 => 182094)


--- trunk/Source/WebInspectorUI/UserInterface/Models/CallFrame.js	2015-03-28 00:54:31 UTC (rev 182093)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CallFrame.js	2015-03-28 00:56:03 UTC (rev 182094)
@@ -81,7 +81,7 @@
 
     collectScopeChainVariableNames(callback)
     {
-        var result = {this: true};
+        var result = {this: true, __proto__: null};
 
         var pendingRequests = this._scopeChain.length;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to