Title: [182137] trunk
- Revision
- 182137
- Author
- commit-qu...@webkit.org
- Date
- 2015-03-30 05:41:02 -0700 (Mon, 30 Mar 2015)
Log Message
Source/WebCore:
Add support for deleting emoji on GTK
https://bugs.webkit.org/show_bug.cgi?id=141419
Patch by Marcos Chavarría Teijeiro <chavarria1...@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.
The code for deleting special group of characters was specific for
COCOA and EFL platforms. The fix consists on add GTK to the #if
preprocessor directive.
* rendering/RenderText.cpp:
(WebCore::RenderText::previousOffsetForBackwardDeletion):
LayoutTests:
Update expectations for delete-emoji test since the bug is fixed now.
https://bugs.webkit.org/show_bug.cgi?id=141419
Patch by Marcos Chavarría Teijeiro <chavarria1...@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (182136 => 182137)
--- trunk/LayoutTests/ChangeLog 2015-03-30 12:22:24 UTC (rev 182136)
+++ trunk/LayoutTests/ChangeLog 2015-03-30 12:41:02 UTC (rev 182137)
@@ -1,3 +1,12 @@
+2015-03-30 Marcos Chavarría Teijeiro <chavarria1...@gmail.com>
+
+ Update expectations for delete-emoji test since the bug is fixed now.
+ https://bugs.webkit.org/show_bug.cgi?id=141419
+
+ Reviewed by Gustavo Noronha Silva.
+
+ * platform/gtk/TestExpectations:
+
2015-03-29 Benjamin Poulain <benja...@webkit.org>
`currentColor` computes to the same colour on all elements, even if 'color' is inherited differently
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (182136 => 182137)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-03-30 12:22:24 UTC (rev 182136)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-03-30 12:41:02 UTC (rev 182137)
@@ -540,7 +540,6 @@
webkit.org/b/141072 accessibility/frame-disconnect-textmarker-cache-crash.html [ Failure ]
webkit.org/b/141423 css3/calc/line-height.html [ Failure ]
-webkit.org/b/141419 editing/deleting/delete-emoji.html [ Failure ]
webkit.org/b/141423 editing/pasteboard/simplfiying-markup-should-not-strip-content.html [ Failure ]
webkit.org/b/141423 fast/css/font-shorthand-from-longhands.html [ Failure ]
webkit.org/b/141423 fast/css/font-shorthand-line-height.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (182136 => 182137)
--- trunk/Source/WebCore/ChangeLog 2015-03-30 12:22:24 UTC (rev 182136)
+++ trunk/Source/WebCore/ChangeLog 2015-03-30 12:41:02 UTC (rev 182137)
@@ -1,3 +1,17 @@
+2015-03-30 Marcos Chavarría Teijeiro <chavarria1...@gmail.com>
+
+ Add support for deleting emoji on GTK
+ https://bugs.webkit.org/show_bug.cgi?id=141419
+
+ Reviewed by Gustavo Noronha Silva.
+
+ The code for deleting special group of characters was specific for
+ COCOA and EFL platforms. The fix consists on add GTK to the #if
+ preprocessor directive.
+
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::previousOffsetForBackwardDeletion):
+
2015-03-30 Benjamin Poulain <benja...@webkit.org>
Start the features.json files
Modified: trunk/Source/WebCore/rendering/RenderText.cpp (182136 => 182137)
--- trunk/Source/WebCore/rendering/RenderText.cpp 2015-03-30 12:22:24 UTC (rev 182136)
+++ trunk/Source/WebCore/rendering/RenderText.cpp 2015-03-30 12:41:02 UTC (rev 182137)
@@ -1401,7 +1401,7 @@
return result;
}
-#if PLATFORM(COCOA) || PLATFORM(EFL)
+#if PLATFORM(COCOA) || PLATFORM(EFL) || PLATFORM(GTK)
#define HANGUL_CHOSEONG_START (0x1100)
#define HANGUL_CHOSEONG_END (0x115F)
@@ -1443,7 +1443,7 @@
int RenderText::previousOffsetForBackwardDeletion(int current) const
{
-#if PLATFORM(COCOA) || PLATFORM(EFL)
+#if PLATFORM(COCOA) || PLATFORM(EFL) || PLATFORM(GTK)
ASSERT(m_text);
StringImpl& text = *m_text.impl();
UChar32 character;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
