Title: [183930] trunk/Source/WebKit2
- Revision
- 183930
- Author
- carlo...@webkit.org
- Date
- 2015-05-07 09:46:05 -0700 (Thu, 07 May 2015)
Log Message
REGRESSION(r182032): [GTK] Production build is broken after r182032
https://bugs.webkit.org/show_bug.cgi?id=144736
Reviewed by Martin Robinson.
The problem is that r182032 moved the NetworkProcess sources from
WebKit2 sources to NetworkProcess sources. That's not a problem
for developer builds where all internal symbols are exported, but
doesn't work for production builds because all those internal
symbols are private.
* CMakeLists.txt: Use a different name for common network process
sources variable.
* PlatformMac.cmake: Append common network process sources to the
network process source list for Mac.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (183929 => 183930)
--- trunk/Source/WebKit2/CMakeLists.txt 2015-05-07 16:26:59 UTC (rev 183929)
+++ trunk/Source/WebKit2/CMakeLists.txt 2015-05-07 16:46:05 UTC (rev 183930)
@@ -154,7 +154,7 @@
)
endif ()
-set(NetworkProcess_SOURCES
+set(NetworkProcess_COMMON_SOURCES
NetworkProcess/NetworkConnectionToWebProcess.cpp
NetworkProcess/NetworkProcess.cpp
NetworkProcess/NetworkProcessPlatformStrategies.cpp
@@ -625,7 +625,7 @@
WebProcess/WebPage/VisitedLinkTableController.cpp
WebProcess/WebPage/WebUndoStep.cpp
- ${NetworkProcess_SOURCES}
+ ${NetworkProcess_COMMON_SOURCES}
)
set(WebKit2_MESSAGES_IN_FILES
Modified: trunk/Source/WebKit2/ChangeLog (183929 => 183930)
--- trunk/Source/WebKit2/ChangeLog 2015-05-07 16:26:59 UTC (rev 183929)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-07 16:46:05 UTC (rev 183930)
@@ -1,3 +1,21 @@
+2015-05-07 Carlos Garcia Campos <cgar...@igalia.com>
+
+ REGRESSION(r182032): [GTK] Production build is broken after r182032
+ https://bugs.webkit.org/show_bug.cgi?id=144736
+
+ Reviewed by Martin Robinson.
+
+ The problem is that r182032 moved the NetworkProcess sources from
+ WebKit2 sources to NetworkProcess sources. That's not a problem
+ for developer builds where all internal symbols are exported, but
+ doesn't work for production builds because all those internal
+ symbols are private.
+
+ * CMakeLists.txt: Use a different name for common network process
+ sources variable.
+ * PlatformMac.cmake: Append common network process sources to the
+ network process source list for Mac.
+
2015-05-07 Dan Bernstein <m...@apple.com>
<rdar://problem/19317140> [Xcode] Remove usage of AspenFamily.xcconfig in Source/
Modified: trunk/Source/WebKit2/PlatformMac.cmake (183929 => 183930)
--- trunk/Source/WebKit2/PlatformMac.cmake 2015-05-07 16:26:59 UTC (rev 183929)
+++ trunk/Source/WebKit2/PlatformMac.cmake 2015-05-07 16:46:05 UTC (rev 183930)
@@ -32,6 +32,10 @@
WebProcess/mac/SecItemShimLibrary.mm
)
+list(APPEND NetworkProcess_SOURCES
+ ${NetworkProcess_COMMON_SOURCES}
+)
+
add_definitions("-include WebKit2Prefix.h")
set(WebKit2_FORWARDING_HEADERS_FILES
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
