Diff
Modified: trunk/Source/WebCore/ChangeLog (183974 => 183975)
--- trunk/Source/WebCore/ChangeLog 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/ChangeLog 2015-05-08 02:18:32 UTC (rev 183975)
@@ -1,3 +1,57 @@
+2015-05-07 Gyuyoung Kim <gyuyoung....@samsung.com>
+
+ Purge PassRefPtr in WebCore/html - 3
+ https://bugs.webkit.org/show_bug.cgi?id=144686
+
+ Reviewed by Andreas Kling.
+
+ Replace PassRefPtr with Ref in create() factory functions, because
+ it doesn't have to change to be null.
+
+ No new tests, no behavior changes.
+
+ * html/FTPDirectoryDocument.h:
+ * html/HTMLDetailsElement.cpp:
+ (WebCore::DetailsContentElement::create):
+ * html/HTMLKeygenElement.cpp:
+ * html/HTMLSummaryElement.cpp:
+ (WebCore::SummaryContentElement::create):
+ * html/TimeRanges.cpp:
+ (WebCore::TimeRanges::create):
+ * html/shadow/SliderThumbElement.cpp:
+ (WebCore::SliderContainerElement::create):
+ * html/shadow/SliderThumbElement.h:
+ (WebCore::SliderThumbElement::create):
+ * html/shadow/SpinButtonElement.cpp:
+ (WebCore::SpinButtonElement::create):
+ * html/shadow/SpinButtonElement.h:
+ * html/shadow/TextControlInnerElements.cpp:
+ (WebCore::TextControlInnerContainer::create):
+ (WebCore::TextControlInnerElement::create):
+ (WebCore::TextControlInnerTextElement::create):
+ (WebCore::SearchFieldResultsButtonElement::create):
+ (WebCore::SearchFieldCancelButtonElement::create):
+ * html/shadow/TextControlInnerElements.h:
+ * html/shadow/YouTubeEmbedShadowElement.cpp:
+ (WebCore::YouTubeEmbedShadowElement::create):
+ * html/track/InbandDataTextTrack.cpp:
+ (WebCore::InbandDataTextTrack::create):
+ * html/track/InbandDataTextTrack.h:
+ * html/track/InbandGenericTextTrack.cpp:
+ (WebCore::InbandGenericTextTrack::create):
+ * html/track/InbandGenericTextTrack.h:
+ * html/track/InbandWebVTTTextTrack.cpp:
+ (WebCore::InbandWebVTTTextTrack::create):
+ * html/track/InbandWebVTTTextTrack.h:
+ * html/track/LoadableTextTrack.h:
+ * html/track/TextTrack.h:
+ (WebCore::TextTrack::create):
+ * html/track/TextTrackCueGeneric.cpp:
+ * html/track/TextTrackCueGeneric.h:
+ * html/track/TextTrackList.h:
+ * html/track/VTTRegionList.h:
+ (WebCore::VTTRegionList::create):
+
2015-05-07 Dean Jackson <d...@apple.com>
[iOS] MediaControls: disappear while scrubbing
Modified: trunk/Source/WebCore/html/FTPDirectoryDocument.h (183974 => 183975)
--- trunk/Source/WebCore/html/FTPDirectoryDocument.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/FTPDirectoryDocument.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -33,9 +33,9 @@
class FTPDirectoryDocument final : public HTMLDocument {
public:
- static RefPtr<FTPDirectoryDocument> create(Frame* frame, const URL& url)
+ static Ref<FTPDirectoryDocument> create(Frame* frame, const URL& url)
{
- return adoptRef(new FTPDirectoryDocument(frame, url));
+ return adoptRef(*new FTPDirectoryDocument(frame, url));
}
private:
Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -42,7 +42,7 @@
class DetailsContentElement final : public InsertionPoint {
public:
- static RefPtr<DetailsContentElement> create(Document&);
+ static Ref<DetailsContentElement> create(Document&);
private:
DetailsContentElement(Document& document)
@@ -58,9 +58,9 @@
}
};
-RefPtr<DetailsContentElement> DetailsContentElement::create(Document& document)
+Ref<DetailsContentElement> DetailsContentElement::create(Document& document)
{
- return adoptRef(new DetailsContentElement(document));
+ return adoptRef(*new DetailsContentElement(document));
}
class DetailsSummaryElement final : public InsertionPoint {
Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -44,9 +44,9 @@
class KeygenSelectElement final : public HTMLSelectElement {
public:
- static RefPtr<KeygenSelectElement> create(Document& document)
+ static Ref<KeygenSelectElement> create(Document& document)
{
- return adoptRef(new KeygenSelectElement(document));
+ return adoptRef(*new KeygenSelectElement(document));
}
protected:
Modified: trunk/Source/WebCore/html/HTMLSummaryElement.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/HTMLSummaryElement.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/HTMLSummaryElement.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -38,7 +38,7 @@
class SummaryContentElement final : public InsertionPoint {
public:
- static RefPtr<SummaryContentElement> create(Document&);
+ static Ref<SummaryContentElement> create(Document&);
private:
SummaryContentElement(Document& document)
@@ -47,9 +47,9 @@
}
};
-RefPtr<SummaryContentElement> SummaryContentElement::create(Document& document)
+Ref<SummaryContentElement> SummaryContentElement::create(Document& document)
{
- return adoptRef(new SummaryContentElement(document));
+ return adoptRef(*new SummaryContentElement(document));
}
Ref<HTMLSummaryElement> HTMLSummaryElement::create(const QualifiedName& tagName, Document& document)
Modified: trunk/Source/WebCore/html/TimeRanges.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/TimeRanges.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/TimeRanges.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -32,19 +32,19 @@
namespace WebCore {
-PassRefPtr<TimeRanges> TimeRanges::create()
+Ref<TimeRanges> TimeRanges::create()
{
- return adoptRef(new TimeRanges);
+ return adoptRef(*new TimeRanges);
}
-PassRefPtr<TimeRanges> TimeRanges::create(double start, double end)
+Ref<TimeRanges> TimeRanges::create(double start, double end)
{
- return adoptRef(new TimeRanges(start, end));
+ return adoptRef(*new TimeRanges(start, end));
}
-PassRefPtr<TimeRanges> TimeRanges::create(const PlatformTimeRanges& other)
+Ref<TimeRanges> TimeRanges::create(const PlatformTimeRanges& other)
{
- return adoptRef(new TimeRanges(other));
+ return adoptRef(*new TimeRanges(other));
}
TimeRanges::TimeRanges()
Modified: trunk/Source/WebCore/html/TimeRanges.h (183974 => 183975)
--- trunk/Source/WebCore/html/TimeRanges.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/TimeRanges.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -38,9 +38,9 @@
class TimeRanges : public RefCounted<TimeRanges> {
public:
- WEBCORE_EXPORT static PassRefPtr<TimeRanges> create();
- WEBCORE_EXPORT static PassRefPtr<TimeRanges> create(double start, double end);
- static PassRefPtr<TimeRanges> create(const PlatformTimeRanges&);
+ WEBCORE_EXPORT static Ref<TimeRanges> create();
+ WEBCORE_EXPORT static Ref<TimeRanges> create(double start, double end);
+ static Ref<TimeRanges> create(const PlatformTimeRanges&);
WEBCORE_EXPORT double start(unsigned index, ExceptionCode&) const;
WEBCORE_EXPORT double end(unsigned index, ExceptionCode&) const;
Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -610,9 +610,9 @@
{
}
-PassRefPtr<SliderContainerElement> SliderContainerElement::create(Document& document)
+Ref<SliderContainerElement> SliderContainerElement::create(Document& document)
{
- return adoptRef(new SliderContainerElement(document));
+ return adoptRef(*new SliderContainerElement(document));
}
RenderPtr<RenderElement> SliderContainerElement::createElementRenderer(Ref<RenderStyle>&& style, const RenderTreePosition&)
Modified: trunk/Source/WebCore/html/shadow/SliderThumbElement.h (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/SliderThumbElement.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/SliderThumbElement.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -45,7 +45,7 @@
class SliderThumbElement final : public HTMLDivElement {
public:
- static PassRefPtr<SliderThumbElement> create(Document&);
+ static Ref<SliderThumbElement> create(Document&);
void setPositionFromValue();
void dragFrom(const LayoutPoint&);
@@ -107,9 +107,9 @@
#endif
};
-inline PassRefPtr<SliderThumbElement> SliderThumbElement::create(Document& document)
+inline Ref<SliderThumbElement> SliderThumbElement::create(Document& document)
{
- return adoptRef(new SliderThumbElement(document));
+ return adoptRef(*new SliderThumbElement(document));
}
// --------------------------------
@@ -127,7 +127,7 @@
class SliderContainerElement final : public HTMLDivElement {
public:
- static PassRefPtr<SliderContainerElement> create(Document&);
+ static Ref<SliderContainerElement> create(Document&);
private:
SliderContainerElement(Document&);
Modified: trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -55,9 +55,9 @@
setPseudo(AtomicString("-webkit-inner-spin-button", AtomicString::ConstructFromLiteral));
}
-PassRefPtr<SpinButtonElement> SpinButtonElement::create(Document& document, SpinButtonOwner& spinButtonOwner)
+Ref<SpinButtonElement> SpinButtonElement::create(Document& document, SpinButtonOwner& spinButtonOwner)
{
- return adoptRef(new SpinButtonElement(document, spinButtonOwner));
+ return adoptRef(*new SpinButtonElement(document, spinButtonOwner));
}
void SpinButtonElement::willDetachRenderers()
Modified: trunk/Source/WebCore/html/shadow/SpinButtonElement.h (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/SpinButtonElement.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/SpinButtonElement.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -54,7 +54,7 @@
// The owner of SpinButtonElement must call removeSpinButtonOwner
// because SpinButtonElement can be outlive SpinButtonOwner
// implementation, e.g. during event handling.
- static PassRefPtr<SpinButtonElement> create(Document&, SpinButtonOwner&);
+ static Ref<SpinButtonElement> create(Document&, SpinButtonOwner&);
UpDownState upDownState() const { return m_upDownState; }
void releaseCapture();
void removeSpinButtonOwner() { m_spinButtonOwner = 0; }
Modified: trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -51,9 +51,9 @@
{
}
-PassRefPtr<TextControlInnerContainer> TextControlInnerContainer::create(Document& document)
+Ref<TextControlInnerContainer> TextControlInnerContainer::create(Document& document)
{
- return adoptRef(new TextControlInnerContainer(document));
+ return adoptRef(*new TextControlInnerContainer(document));
}
RenderPtr<RenderElement> TextControlInnerContainer::createElementRenderer(Ref<RenderStyle>&& style, const RenderTreePosition&)
@@ -67,9 +67,9 @@
setHasCustomStyleResolveCallbacks();
}
-PassRefPtr<TextControlInnerElement> TextControlInnerElement::create(Document& document)
+Ref<TextControlInnerElement> TextControlInnerElement::create(Document& document)
{
- return adoptRef(new TextControlInnerElement(document));
+ return adoptRef(*new TextControlInnerElement(document));
}
RefPtr<RenderStyle> TextControlInnerElement::customStyleForRenderer(RenderStyle&)
@@ -86,9 +86,9 @@
setHasCustomStyleResolveCallbacks();
}
-PassRefPtr<TextControlInnerTextElement> TextControlInnerTextElement::create(Document& document)
+Ref<TextControlInnerTextElement> TextControlInnerTextElement::create(Document& document)
{
- return adoptRef(new TextControlInnerTextElement(document));
+ return adoptRef(*new TextControlInnerTextElement(document));
}
void TextControlInnerTextElement::defaultEventHandler(Event* event)
@@ -133,9 +133,9 @@
{
}
-PassRefPtr<SearchFieldResultsButtonElement> SearchFieldResultsButtonElement::create(Document& document)
+Ref<SearchFieldResultsButtonElement> SearchFieldResultsButtonElement::create(Document& document)
{
- return adoptRef(new SearchFieldResultsButtonElement(document));
+ return adoptRef(*new SearchFieldResultsButtonElement(document));
}
void SearchFieldResultsButtonElement::defaultEventHandler(Event* event)
@@ -176,9 +176,9 @@
setHasCustomStyleResolveCallbacks();
}
-PassRefPtr<SearchFieldCancelButtonElement> SearchFieldCancelButtonElement::create(Document& document)
+Ref<SearchFieldCancelButtonElement> SearchFieldCancelButtonElement::create(Document& document)
{
- return adoptRef(new SearchFieldCancelButtonElement(document));
+ return adoptRef(*new SearchFieldCancelButtonElement(document));
}
void SearchFieldCancelButtonElement::willDetachRenderers()
Modified: trunk/Source/WebCore/html/shadow/TextControlInnerElements.h (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/TextControlInnerElements.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/TextControlInnerElements.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -36,7 +36,7 @@
class TextControlInnerContainer final : public HTMLDivElement {
public:
- static PassRefPtr<TextControlInnerContainer> create(Document&);
+ static Ref<TextControlInnerContainer> create(Document&);
protected:
TextControlInnerContainer(Document&);
virtual RenderPtr<RenderElement> createElementRenderer(Ref<RenderStyle>&&, const RenderTreePosition&) override;
@@ -44,7 +44,7 @@
class TextControlInnerElement final : public HTMLDivElement {
public:
- static PassRefPtr<TextControlInnerElement> create(Document&);
+ static Ref<TextControlInnerElement> create(Document&);
protected:
TextControlInnerElement(Document&);
@@ -56,7 +56,7 @@
class TextControlInnerTextElement final : public HTMLDivElement {
public:
- static PassRefPtr<TextControlInnerTextElement> create(Document&);
+ static Ref<TextControlInnerTextElement> create(Document&);
virtual void defaultEventHandler(Event*) override;
@@ -72,7 +72,7 @@
class SearchFieldResultsButtonElement final : public HTMLDivElement {
public:
- static PassRefPtr<SearchFieldResultsButtonElement> create(Document&);
+ static Ref<SearchFieldResultsButtonElement> create(Document&);
virtual void defaultEventHandler(Event*) override;
#if !PLATFORM(IOS)
@@ -86,7 +86,7 @@
class SearchFieldCancelButtonElement final : public HTMLDivElement {
public:
- static PassRefPtr<SearchFieldCancelButtonElement> create(Document&);
+ static Ref<SearchFieldCancelButtonElement> create(Document&);
virtual void defaultEventHandler(Event*) override;
virtual bool isSearchFieldCancelButtonElement() const override { return true; }
Modified: trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -30,9 +30,9 @@
namespace WebCore {
-PassRefPtr<YouTubeEmbedShadowElement> YouTubeEmbedShadowElement::create(Document& doc)
+Ref<YouTubeEmbedShadowElement> YouTubeEmbedShadowElement::create(Document& doc)
{
- return adoptRef(new YouTubeEmbedShadowElement(doc));
+ return adoptRef(*new YouTubeEmbedShadowElement(doc));
}
YouTubeEmbedShadowElement::YouTubeEmbedShadowElement(Document& document)
Modified: trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h (183974 => 183975)
--- trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -33,7 +33,7 @@
class YouTubeEmbedShadowElement final : public HTMLDivElement {
public:
- static PassRefPtr<YouTubeEmbedShadowElement> create(Document&);
+ static Ref<YouTubeEmbedShadowElement> create(Document&);
private:
YouTubeEmbedShadowElement(Document&);
Modified: trunk/Source/WebCore/html/track/InbandDataTextTrack.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/track/InbandDataTextTrack.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/InbandDataTextTrack.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -38,9 +38,9 @@
namespace WebCore {
-PassRefPtr<InbandDataTextTrack> InbandDataTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
+Ref<InbandDataTextTrack> InbandDataTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
{
- return adoptRef(new InbandDataTextTrack(context, client, playerPrivate));
+ return adoptRef(*new InbandDataTextTrack(context, client, playerPrivate));
}
InbandDataTextTrack::InbandDataTextTrack(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> trackPrivate)
Modified: trunk/Source/WebCore/html/track/InbandDataTextTrack.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/InbandDataTextTrack.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/InbandDataTextTrack.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -44,7 +44,7 @@
class InbandDataTextTrack final : public InbandTextTrack {
public:
- static PassRefPtr<InbandDataTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
+ static Ref<InbandDataTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
virtual ~InbandDataTextTrack();
private:
Modified: trunk/Source/WebCore/html/track/InbandGenericTextTrack.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/track/InbandGenericTextTrack.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/InbandGenericTextTrack.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -92,9 +92,9 @@
}
}
-PassRefPtr<InbandGenericTextTrack> InbandGenericTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
+Ref<InbandGenericTextTrack> InbandGenericTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
{
- return adoptRef(new InbandGenericTextTrack(context, client, playerPrivate));
+ return adoptRef(*new InbandGenericTextTrack(context, client, playerPrivate));
}
InbandGenericTextTrack::InbandGenericTextTrack(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> trackPrivate)
Modified: trunk/Source/WebCore/html/track/InbandGenericTextTrack.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/InbandGenericTextTrack.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/InbandGenericTextTrack.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -62,7 +62,7 @@
class InbandGenericTextTrack final : public InbandTextTrack, private WebVTTParserClient {
public:
- static PassRefPtr<InbandGenericTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
+ static Ref<InbandGenericTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
virtual ~InbandGenericTextTrack();
private:
Modified: trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -40,9 +40,9 @@
namespace WebCore {
-PassRefPtr<InbandTextTrack> InbandWebVTTTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
+Ref<InbandTextTrack> InbandWebVTTTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
{
- return adoptRef(new InbandWebVTTTextTrack(context, client, playerPrivate));
+ return adoptRef(*new InbandWebVTTTextTrack(context, client, playerPrivate));
}
InbandWebVTTTextTrack::InbandWebVTTTextTrack(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> trackPrivate)
Modified: trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -37,7 +37,7 @@
class InbandWebVTTTextTrack final : public InbandTextTrack, private WebVTTParserClient {
public:
- static PassRefPtr<InbandTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
+ static Ref<InbandTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
virtual ~InbandWebVTTTextTrack();
private:
Modified: trunk/Source/WebCore/html/track/LoadableTextTrack.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/LoadableTextTrack.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/LoadableTextTrack.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -40,9 +40,9 @@
class LoadableTextTrack final : public TextTrack, private TextTrackLoaderClient {
public:
- static PassRefPtr<LoadableTextTrack> create(HTMLTrackElement* track, const String& kind, const String& label, const String& language)
+ static Ref<LoadableTextTrack> create(HTMLTrackElement* track, const String& kind, const String& label, const String& language)
{
- return adoptRef(new LoadableTextTrack(track, kind, label, language));
+ return adoptRef(*new LoadableTextTrack(track, kind, label, language));
}
virtual ~LoadableTextTrack();
Modified: trunk/Source/WebCore/html/track/TextTrack.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/track/TextTrack.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/TextTrack.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -103,14 +103,14 @@
TextTrack* TextTrack::captionMenuOffItem()
{
- static TextTrack* off = TextTrack::create(0, 0, "off menu item", "", "", "").leakRef();
- return off;
+ static TextTrack& off = TextTrack::create(0, 0, "off menu item", "", "", "").leakRef();
+ return &off;
}
TextTrack* TextTrack::captionMenuAutomaticItem()
{
- static TextTrack* automatic = TextTrack::create(0, 0, "automatic menu item", "", "", "").leakRef();
- return automatic;
+ static TextTrack& automatic = TextTrack::create(0, 0, "automatic menu item", "", "", "").leakRef();
+ return &automatic;
}
TextTrack::TextTrack(ScriptExecutionContext* context, TextTrackClient* client, const AtomicString& kind, const AtomicString& id, const AtomicString& label, const AtomicString& language, TextTrackType type)
Modified: trunk/Source/WebCore/html/track/TextTrack.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/TextTrack.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/TextTrack.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -67,9 +67,9 @@
#endif
{
public:
- static PassRefPtr<TextTrack> create(ScriptExecutionContext* context, TextTrackClient* client, const AtomicString& kind, const AtomicString& id, const AtomicString& label, const AtomicString& language)
+ static Ref<TextTrack> create(ScriptExecutionContext* context, TextTrackClient* client, const AtomicString& kind, const AtomicString& id, const AtomicString& label, const AtomicString& language)
{
- return adoptRef(new TextTrack(context, client, kind, id, label, language, AddTrack));
+ return adoptRef(*new TextTrack(context, client, kind, id, label, language, AddTrack));
}
virtual ~TextTrack();
Modified: trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp (183974 => 183975)
--- trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -49,9 +49,9 @@
class TextTrackCueGenericBoxElement final : public VTTCueBox {
public:
- static PassRefPtr<TextTrackCueGenericBoxElement> create(Document& document, TextTrackCueGeneric& cue)
+ static Ref<TextTrackCueGenericBoxElement> create(Document& document, TextTrackCueGeneric& cue)
{
- return adoptRef(new TextTrackCueGenericBoxElement(document, cue));
+ return adoptRef(*new TextTrackCueGenericBoxElement(document, cue));
}
virtual void applyCSSProperties(const IntSize&) override;
Modified: trunk/Source/WebCore/html/track/TextTrackCueGeneric.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/TextTrackCueGeneric.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/TextTrackCueGeneric.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -38,9 +38,9 @@
// A "generic" cue is a non-WebVTT cue, so it is not positioned/sized with the WebVTT logic.
class TextTrackCueGeneric final : public VTTCue {
public:
- static PassRefPtr<TextTrackCueGeneric> create(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end, const String& content)
+ static Ref<TextTrackCueGeneric> create(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end, const String& content)
{
- return adoptRef(new TextTrackCueGeneric(context, start, end, content));
+ return adoptRef(*new TextTrackCueGeneric(context, start, end, content));
}
virtual ~TextTrackCueGeneric() { }
Modified: trunk/Source/WebCore/html/track/TextTrackList.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/TextTrackList.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/TextTrackList.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -36,9 +36,9 @@
class TextTrackList final : public TrackListBase {
public:
- static PassRefPtr<TextTrackList> create(HTMLMediaElement* element, ScriptExecutionContext* context)
+ static Ref<TextTrackList> create(HTMLMediaElement* element, ScriptExecutionContext* context)
{
- return adoptRef(new TextTrackList(element, context));
+ return adoptRef(*new TextTrackList(element, context));
}
virtual ~TextTrackList();
Modified: trunk/Source/WebCore/html/track/VTTRegionList.h (183974 => 183975)
--- trunk/Source/WebCore/html/track/VTTRegionList.h 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Source/WebCore/html/track/VTTRegionList.h 2015-05-08 02:18:32 UTC (rev 183975)
@@ -38,9 +38,9 @@
class VTTRegionList : public RefCounted<VTTRegionList> {
public:
- static PassRefPtr<VTTRegionList> create()
+ static Ref<VTTRegionList> create()
{
- return adoptRef(new VTTRegionList());
+ return adoptRef(*new VTTRegionList);
}
~VTTRegionList() { }
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp (183974 => 183975)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp 2015-05-08 02:12:35 UTC (rev 183974)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp 2015-05-08 02:18:32 UTC (rev 183975)
@@ -52,12 +52,12 @@
TEST(TimeRanges, Empty)
{
- ASSERT_RANGE("{ }", TimeRanges::create());
+ ASSERT_RANGE("{ }", TimeRanges::create().ptr());
}
TEST(TimeRanges, SingleRange)
{
- ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2));
+ ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2).ptr());
}
TEST(TimeRanges, AddOrder)
