Title: [184436] trunk/Source/WebCore
- Revision
- 184436
- Author
- commit-qu...@webkit.org
- Date
- 2015-05-16 12:57:26 -0700 (Sat, 16 May 2015)
Log Message
Remove MessageType variant of addMessageToConsole() from ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=145095
Patch by Sungmann Cho <sungmann....@navercorp.com> on 2015-05-16
Reviewed by Darin Adler.
All addMessageToConsole() in ChromeClient are exactly the same thing.
So there is no reason to keep all this methods.
No new tests, no behavior change.
* page/ChromeClient.h:
* page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::messageWithTypeAndLevel):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184435 => 184436)
--- trunk/Source/WebCore/ChangeLog 2015-05-16 18:16:26 UTC (rev 184435)
+++ trunk/Source/WebCore/ChangeLog 2015-05-16 19:57:26 UTC (rev 184436)
@@ -1,3 +1,19 @@
+2015-05-16 Sungmann Cho <sungmann....@navercorp.com>
+
+ Remove MessageType variant of addMessageToConsole() from ChromeClient.
+ https://bugs.webkit.org/show_bug.cgi?id=145095
+
+ Reviewed by Darin Adler.
+
+ All addMessageToConsole() in ChromeClient are exactly the same thing.
+ So there is no reason to keep all this methods.
+
+ No new tests, no behavior change.
+
+ * page/ChromeClient.h:
+ * page/PageConsoleClient.cpp:
+ (WebCore::PageConsoleClient::messageWithTypeAndLevel):
+
2015-05-15 Sam Weinig <s...@webkit.org>
Add getElementById to DocumentFragment
Modified: trunk/Source/WebCore/page/ChromeClient.h (184435 => 184436)
--- trunk/Source/WebCore/page/ChromeClient.h 2015-05-16 18:16:26 UTC (rev 184435)
+++ trunk/Source/WebCore/page/ChromeClient.h 2015-05-16 19:57:26 UTC (rev 184436)
@@ -136,11 +136,6 @@
virtual void setResizable(bool) = 0;
virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, unsigned columnNumber, const String& sourceID) = 0;
- // FIXME: Remove this MessageType variant once all the clients are updated.
- virtual void addMessageToConsole(MessageSource source, MessageType, MessageLevel level, const String& message, unsigned lineNumber, unsigned columnNumber, const String& sourceID)
- {
- addMessageToConsole(source, level, message, lineNumber, columnNumber, sourceID);
- }
virtual bool canRunBeforeUnloadConfirmPanel() = 0;
virtual bool runBeforeUnloadConfirmPanel(const String& message, Frame*) = 0;
Modified: trunk/Source/WebCore/page/PageConsoleClient.cpp (184435 => 184436)
--- trunk/Source/WebCore/page/PageConsoleClient.cpp 2015-05-16 18:16:26 UTC (rev 184435)
+++ trunk/Source/WebCore/page/PageConsoleClient.cpp 2015-05-16 19:57:26 UTC (rev 184436)
@@ -169,7 +169,7 @@
return;
if (gotMessage)
- m_page.chrome().client().addMessageToConsole(MessageSource::ConsoleAPI, type, level, messageText, lineNumber, columnNumber, url);
+ m_page.chrome().client().addMessageToConsole(MessageSource::ConsoleAPI, level, messageText, lineNumber, columnNumber, url);
if (m_page.settings().logsPageMessagesToSystemConsoleEnabled() || PageConsoleClient::shouldPrintExceptions())
ConsoleClient::printConsoleMessageWithArguments(MessageSource::ConsoleAPI, type, level, exec, WTF::move(arguments));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
