Title: [185004] trunk/Source/WebCore
- Revision
- 185004
- Author
- achristen...@apple.com
- Date
- 2015-05-29 14:20:48 -0700 (Fri, 29 May 2015)
Log Message
[Content Extensions] Decrease maxNFASize
https://bugs.webkit.org/show_bug.cgi?id=145461
Reviewed by Gavin Barraclough.
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
Decrease maxNFASize based on analysis of memory usage and compiling and interpreting time.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (185003 => 185004)
--- trunk/Source/WebCore/ChangeLog 2015-05-29 20:59:20 UTC (rev 185003)
+++ trunk/Source/WebCore/ChangeLog 2015-05-29 21:20:48 UTC (rev 185004)
@@ -1,3 +1,14 @@
+2015-05-29 Alex Christensen <achristen...@webkit.org>
+
+ [Content Extensions] Decrease maxNFASize
+ https://bugs.webkit.org/show_bug.cgi?id=145461
+
+ Reviewed by Gavin Barraclough.
+
+ * contentextensions/ContentExtensionCompiler.cpp:
+ (WebCore::ContentExtensions::compileRuleList):
+ Decrease maxNFASize based on analysis of memory usage and compiling and interpreting time.
+
2015-05-29 Brady Eidson <beid...@apple.com>
WebSQL default functions can bypass authorizer.
Modified: trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp (185003 => 185004)
--- trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2015-05-29 20:59:20 UTC (rev 185003)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2015-05-29 21:20:48 UTC (rev 185004)
@@ -238,8 +238,9 @@
double totalNFAToByteCodeBuildTimeStart = monotonicallyIncreasingTime();
#endif
- // FIXME: This can be tuned. More NFAs take longer to interpret, fewer use more memory and time to compile.
- const unsigned maxNFASize = 50000;
+ // Smaller maxNFASizes risk high compiling and interpreting times from having too many DFAs,
+ // larger maxNFASizes use too much memory when compiling.
+ const unsigned maxNFASize = 30000;
bool firstNFAWithoutDomainsSeen = false;
// FIXME: Combine small NFAs to reduce the number of NFAs.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
