Title: [185092] trunk/Source/WebKit2
- Revision
- 185092
- Author
- enr...@apple.com
- Date
- 2015-06-01 18:27:05 -0700 (Mon, 01 Jun 2015)
Log Message
[iOS] Hardware Keyboard: All combinations for arrow keys with Shift do not extend the selection.
https://bugs.webkit.org/show_bug.cgi?id=145538
rdar://problem/18504199
Reviewed by Darin Adler.
The extend parameter was ignored in all the functions below.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _moveUp:withHistory:]):
(-[WKContentView _moveDown:withHistory:]):
(-[WKContentView _moveLeft:withHistory:]):
(-[WKContentView _moveRight:withHistory:]):
(-[WKContentView _moveToStartOfWord:withHistory:]):
(-[WKContentView _moveToStartOfParagraph:withHistory:]):
(-[WKContentView _moveToStartOfLine:withHistory:]):
(-[WKContentView _moveToStartOfDocument:withHistory:]):
(-[WKContentView _moveToEndOfWord:withHistory:]):
(-[WKContentView _moveToEndOfParagraph:withHistory:]):
(-[WKContentView _moveToEndOfLine:withHistory:]):
(-[WKContentView _moveToEndOfDocument:withHistory:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (185091 => 185092)
--- trunk/Source/WebKit2/ChangeLog 2015-06-02 01:04:32 UTC (rev 185091)
+++ trunk/Source/WebKit2/ChangeLog 2015-06-02 01:27:05 UTC (rev 185092)
@@ -1,3 +1,27 @@
+2015-06-01 Enrica Casucci <enr...@apple.com>
+
+ [iOS] Hardware Keyboard: All combinations for arrow keys with Shift do not extend the selection.
+ https://bugs.webkit.org/show_bug.cgi?id=145538
+ rdar://problem/18504199
+
+ Reviewed by Darin Adler.
+
+ The extend parameter was ignored in all the functions below.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _moveUp:withHistory:]):
+ (-[WKContentView _moveDown:withHistory:]):
+ (-[WKContentView _moveLeft:withHistory:]):
+ (-[WKContentView _moveRight:withHistory:]):
+ (-[WKContentView _moveToStartOfWord:withHistory:]):
+ (-[WKContentView _moveToStartOfParagraph:withHistory:]):
+ (-[WKContentView _moveToStartOfLine:withHistory:]):
+ (-[WKContentView _moveToStartOfDocument:withHistory:]):
+ (-[WKContentView _moveToEndOfWord:withHistory:]):
+ (-[WKContentView _moveToEndOfParagraph:withHistory:]):
+ (-[WKContentView _moveToEndOfLine:withHistory:]):
+ (-[WKContentView _moveToEndOfDocument:withHistory:]):
+
2015-06-01 Anders Carlsson <ander...@apple.com>
Use xpc_connection_set_oneshot_instance where possible
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (185091 => 185092)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-06-02 01:04:32 UTC (rev 185091)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-06-02 01:27:05 UTC (rev 185092)
@@ -2659,73 +2659,73 @@
- (UITextInputArrowKeyHistory *)_moveUp:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveUp"];
+ [self executeEditCommandWithCallback:extending ? @"moveUpAndModifySelection" : @"moveUp"];
return nil;
}
- (UITextInputArrowKeyHistory *)_moveDown:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveDown"];
+ [self executeEditCommandWithCallback:extending ? @"moveDownAndModifySelection" : @"moveDown"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveLeft:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveLeft:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveLeft"];
+ [self executeEditCommandWithCallback:extending? @"moveLeftAndModifySelection" : @"moveLeft"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveRight:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveRight:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveRight"];
+ [self executeEditCommandWithCallback:extending ? @"moveRightAndModifySelection" : @"moveRight"];
return nil;
}
- (UITextInputArrowKeyHistory *)_moveToStartOfWord:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveWordBackward"];
+ [self executeEditCommandWithCallback:extending ? @"moveWordBackwardAndModifySelection" : @"moveWordBackward"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveToStartOfParagraph:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveToStartOfParagraph:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveToStartOfParagraph"];
+ [self executeEditCommandWithCallback:extending ? @"moveToBeginningOfParagraphAndModifySelection" : @"moveToBeginningOfParagraph"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveToStartOfLine:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveToStartOfLine:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveToBeginningOfLine"];
+ [self executeEditCommandWithCallback:extending ? @"moveToBeginningOfLineAndModifySelection" : @"moveToBeginningOfLine"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveToStartOfDocument:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveToStartOfDocument:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveToBeginningOfDocument"];
+ [self executeEditCommandWithCallback:extending ? @"moveToBeginningOfDocumentAndModifySelection" : @"moveToBeginningOfDocument"];
return nil;
}
- (UITextInputArrowKeyHistory *)_moveToEndOfWord:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveWordForward"];
+ [self executeEditCommandWithCallback:extending ? @"moveWordForwardAndModifySelection" : @"moveWordForward"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveToEndOfParagraph:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveToEndOfParagraph:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveToEndOfParagraph"];
+ [self executeEditCommandWithCallback:extending ? @"moveToEndOfParagraphAndModifySelection" : @"moveToEndOfParagraph"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveToEndOfLine:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveToEndOfLine:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveToEndOfLine"];
+ [self executeEditCommandWithCallback:extending ? @"moveToEndOfLineAndModifySelection" : @"moveToEndOfLine"];
return nil;
}
-- (UITextInputArrowKeyHistory *)_moveToEndOfDocument:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+- (UITextInputArrowKeyHistory *)_moveToEndOfDocument:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
{
- [self executeEditCommandWithCallback:@"moveToEndOfDocument"];
+ [self executeEditCommandWithCallback:extending ? @"moveToEndOfDocumentAndModifySelection" : @"moveToEndOfDocument"];
return nil;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes