- Revision
- 185193
- Author
- commit-qu...@webkit.org
- Date
- 2015-06-03 23:45:47 -0700 (Wed, 03 Jun 2015)
Log Message
Added a patch so that the colors displayed on the page could be toggled
in case people need accessibility colors displayed in their browser.
https://bugs.webkit.org/show_bug.cgi?id=145570
<rdar://problem/20994468>
Added in CSS colors and toggle buttons for checkmarks in the page, so that
the page could be rendered in a specific way for accessibility needs if needed.
Patch by Matthew Daiter <mdai...@apple.com> on 2015-06-03
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(updateHiddenPlatforms):
(applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
(toggleAccessibilityColors): Toggle colors on and off
(documentReady): Needed to make changes to the initialization
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(a:hover):
(div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
(div.cellButton.hide, div.accessibilityButton.hide):
(div.cellButton.unhide, div.accessibilityButton.unhide):
(.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
(.popover-tracking:hover):
(.accessibilityButton):
(div.cellButton): Deleted.
(div.cellButton.hide): Deleted.
(div.cellButton.unhide): Deleted.
(.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.neutral .bubble):
(.status-line.unauthorized .bubble):
(.status-line.danger .bubble.pictogram):
(.status-line.bad .bubble.pictogram):
(.status-line.no-bubble .message):
(.status-line.bad .bubble):
(.status-line.good .bubble):
(.status-line.good .message):
(.status-line.bad .message):
(body.accessibility-colors .status-line.good .bubble):
(body.accessibility-colors .status-line.bad .bubble):
(body.accessibility-colors .status-line.good .message):
(body.accessibility-colors .status-line.bad .message):
(.status-line.danger .message):
(.status-line.unauthorized .message):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (185192 => 185193)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-06-04 06:45:47 UTC (rev 185193)
@@ -136,6 +136,32 @@
unhideButton.classList.add("hidden");
}
+function applyAccessibilityColorSetting()
+{
+ var useAccessibleColors = settings.getObject("accessibilityColorsEnabled");
+ var toggleAccessibilityColorButton = document.getElementById("accessibilityButton");
+ if (useAccessibleColors) {
+ toggleAccessibilityColorButton.textContent = "disable accessibility colors";
+ document.body.classList.toggle("accessibility-colors");
+ } else
+ toggleAccessibilityColorButton.textContent = "enable accessibility colors";
+}
+
+function toggleAccessibilityColors()
+{
+ var isCurrentlyActivated = settings.getObject("accessibilityColorsEnabled");
+ if (isCurrentlyActivated === undefined)
+ isCurrentlyActivated = false;
+
+ settings.setObject("accessibilityColorsEnabled", !isCurrentlyActivated);
+ document.body.classList.toggle("accessibility-colors");
+ var toggleAccessibilityColorButton = document.getElementById("accessibilityButton");
+ if (!isCurrentlyActivated)
+ toggleAccessibilityColorButton.textContent = "disable accessibility colors";
+ else
+ toggleAccessibilityColorButton.textContent = "enable accessibility colors";
+}
+
function documentReady()
{
var table = document.createElement("table");
@@ -144,11 +170,12 @@
var row = document.createElement("tr");
row.classList.add("headers");
- var header = document.createElement("th");
+ var header = document.createElement("th");
var unhideButton = document.createElement("div");
unhideButton.addEventListener("click", function () { settings.clearHiddenPlatforms(); });
unhideButton.textContent = "Show All Platforms";
unhideButton.classList.add("cellButton", "unhide", "hidden");
+
header.appendChild(unhideButton);
row.appendChild(header);
@@ -260,6 +287,14 @@
settingsButton.classList.add("settings");
document.body.appendChild(settingsButton);
+ var toggleAccessibilityColorButton = document.createElement("div");
+ toggleAccessibilityColorButton.addEventListener("click", function() { toggleAccessibilityColors(); });
+ toggleAccessibilityColorButton.setAttribute("class", "unhide hidden accessibilityButton");
+ toggleAccessibilityColorButton.setAttribute("id", "accessibilityButton");
+ toggleAccessibilityColorButton.textContent = "enable accessibility colors";
+ document.body.appendChild(toggleAccessibilityColorButton);
+ applyAccessibilityColorSetting();
+
updateHiddenPlatforms();
settings.addSettingListener("hiddenPlatforms", updateHiddenPlatforms);
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (185192 => 185193)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2015-06-04 06:45:47 UTC (rev 185193)
@@ -42,25 +42,26 @@
text-decoration: underline;
}
-div.cellButton {
+div.cellButton, div.accessibilityButton {
font-family: "HelveticaNeue-Light", sans-serif;
font-size: 12px;
color: rgb(185, 175, 125);
cursor: pointer;
}
-div.cellButton.hide {
+div.cellButton.hide, div.accessibilityButton.hide {
display: none;
position: absolute;
bottom: 2px;
right: 4px;
}
-div.cellButton.unhide {
+div.cellButton.unhide, div.accessibilityButton.unhide {
display: none;
}
-.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide {
+.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide,
+.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide {
display: block;
}
@@ -200,3 +201,9 @@
.popover-tracking:hover {
text-shadow: 0px 0px 3px rgba(0, 0, 0, 0.2)
}
+
+.accessibilityButton {
+ position: absolute;
+ left: 45px;
+ top: 13.5px;
+}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (185192 => 185193)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2015-06-04 06:45:47 UTC (rev 185193)
@@ -50,10 +50,6 @@
background-color: rgb(181, 174, 148);
}
-.status-line.good .bubble {
- background-color: rgb(50, 219, 72);
-}
-
.status-line.unauthorized .bubble {
background-color: rgb(171, 61, 171);
}
@@ -80,10 +76,6 @@
font-weight: bold;
}
-.status-line.bad .bubble {
- background-color: rgb(196, 49, 49);
-}
-
.status-line.bad .bubble.pictogram {
font-family: "Menlo-Bold", sans-serif;
font-size: 23px;
@@ -129,21 +121,47 @@
color: rgb(145, 135, 95);
}
+.status-line.bad .bubble {
+ background-color: rgb(191, 67, 41);
+}
+
+.status-line.good .bubble {
+ background-color: rgb(76, 151, 61);
+}
+
.status-line.good .label,
.status-line.good .message {
+ color: rgb(76, 151, 61);
+}
+
+.status-line.bad .label,
+.status-line.bad .message {
+ color: rgb(191, 67, 41);
+}
+
+body.accessibility-colors .status-line.good .bubble {
+ background-color: rgb(50, 219, 72);
+}
+
+body.accessibility-colors .status-line.bad .bubble {
+ background-color: rgb(196, 49, 49);
+}
+
+body.accessibility-colors .status-line.good .label,
+body.accessibility-colors .status-line.good .message {
color: rgb(40, 177, 58);
}
+body.accessibility-colors .status-line.bad .label,
+body.accessibility-colors .status-line.bad .message {
+ color: rgb(191, 67, 41);
+}
+
.status-line.danger .label,
.status-line.danger .message {
color: rgb(230, 175, 44);
}
-.status-line.bad .label,
-.status-line.bad .message {
- color: rgb(191, 67, 41);
-}
-
.status-line.unauthorized .label,
.status-line.unauthorized .message {
color: rgb(171, 61, 171);
Modified: trunk/Tools/ChangeLog (185192 => 185193)
--- trunk/Tools/ChangeLog 2015-06-04 06:23:47 UTC (rev 185192)
+++ trunk/Tools/ChangeLog 2015-06-04 06:45:47 UTC (rev 185193)
@@ -1,3 +1,49 @@
+2015-06-03 Matthew Daiter <mdai...@apple.com>
+
+ Added a patch so that the colors displayed on the page could be toggled
+ in case people need accessibility colors displayed in their browser.
+ https://bugs.webkit.org/show_bug.cgi?id=145570
+ <rdar://problem/20994468>
+
+ Added in CSS colors and toggle buttons for checkmarks in the page, so that
+ the page could be rendered in a specific way for accessibility needs if needed.
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+ (updateHiddenPlatforms):
+ (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
+ (toggleAccessibilityColors): Toggle colors on and off
+ (documentReady): Needed to make changes to the initialization
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ (a:hover):
+ (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
+ (div.cellButton.hide, div.accessibilityButton.hide):
+ (div.cellButton.unhide, div.accessibilityButton.unhide):
+ (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
+ (.popover-tracking:hover):
+ (.accessibilityButton):
+ (div.cellButton): Deleted.
+ (div.cellButton.hide): Deleted.
+ (div.cellButton.unhide): Deleted.
+ (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+ (.status-line.neutral .bubble):
+ (.status-line.unauthorized .bubble):
+ (.status-line.danger .bubble.pictogram):
+ (.status-line.bad .bubble.pictogram):
+ (.status-line.no-bubble .message):
+ (.status-line.bad .bubble):
+ (.status-line.good .bubble):
+ (.status-line.good .message):
+ (.status-line.bad .message):
+ (body.accessibility-colors .status-line.good .bubble):
+ (body.accessibility-colors .status-line.bad .bubble):
+ (body.accessibility-colors .status-line.good .message):
+ (body.accessibility-colors .status-line.bad .message):
+ (.status-line.danger .message):
+ (.status-line.unauthorized .message):
+
2015-06-03 Ryosuke Niwa <rn...@webkit.org>
Unreviewed build fix for Dromaeo.
