Title: [185854] trunk/Source/WebCore
- Revision
- 185854
- Author
- achristen...@apple.com
- Date
- 2015-06-22 18:09:15 -0700 (Mon, 22 Jun 2015)
Log Message
[cssjit] Disable compiling scrollbar pseudoclass selectors
https://bugs.webkit.org/show_bug.cgi?id=146220
Reviewed by Benjamin Poulain.
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addScrollbarPseudoClassType):
Don't compile selectors with scrollbar pseudoclasses.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (185853 => 185854)
--- trunk/Source/WebCore/ChangeLog 2015-06-23 00:51:44 UTC (rev 185853)
+++ trunk/Source/WebCore/ChangeLog 2015-06-23 01:09:15 UTC (rev 185854)
@@ -1,3 +1,14 @@
+2015-06-22 Alex Christensen <achristen...@webkit.org>
+
+ [cssjit] Disable compiling scrollbar pseudoclass selectors
+ https://bugs.webkit.org/show_bug.cgi?id=146220
+
+ Reviewed by Benjamin Poulain.
+
+ * cssjit/SelectorCompiler.cpp:
+ (WebCore::SelectorCompiler::addScrollbarPseudoClassType):
+ Don't compile selectors with scrollbar pseudoclasses.
+
2015-06-22 Simon Fraser <simon.fra...@apple.com>
-webkit-clip-path clips incorrectly if the element bounds go beyond the top edge of the page
Modified: trunk/Source/WebCore/cssjit/SelectorCompiler.cpp (185853 => 185854)
--- trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2015-06-23 00:51:44 UTC (rev 185853)
+++ trunk/Source/WebCore/cssjit/SelectorCompiler.cpp 2015-06-23 01:09:15 UTC (rev 185854)
@@ -435,6 +435,11 @@
static inline FunctionType addScrollbarPseudoClassType(const CSSSelector& selector, SelectorFragment& fragment)
{
+ // FIXME: scrollbar pseudoclass interaction with :not doesn't behave correctly.
+ // Compile them when they are fixed and tested.
+ // https://bugs.webkit.org/show_bug.cgi?id=146221
+ return FunctionType::CannotCompile;
+
switch (selector.pseudoClassType()) {
case CSSSelector::PseudoClassWindowInactive:
fragment.unoptimizedPseudoClasses.append(JSC::FunctionPtr(isWindowInactive));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes