Title: [185892] trunk/Source/WebInspectorUI
- Revision
- 185892
- Author
- commit-qu...@webkit.org
- Date
- 2015-06-23 17:29:11 -0700 (Tue, 23 Jun 2015)
Log Message
Web Inspector: Reduce QuickConsole DidResize events if it did not change
https://bugs.webkit.org/show_bug.cgi?id=146258
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-06-23
Reviewed by Timothy Hatcher.
* UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype.consoleLogVisibilityChanged):
Do not trigger the event unless there was a change in visibility.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185891 => 185892)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-24 00:27:29 UTC (rev 185891)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-24 00:29:11 UTC (rev 185892)
@@ -1,5 +1,16 @@
2015-06-23 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Reduce QuickConsole DidResize events if it did not change
+ https://bugs.webkit.org/show_bug.cgi?id=146258
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/QuickConsole.js:
+ (WebInspector.QuickConsole.prototype.consoleLogVisibilityChanged):
+ Do not trigger the event unless there was a change in visibility.
+
+2015-06-23 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: TextEditor scroll position not correctly restored when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=146254
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (185891 => 185892)
--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2015-06-24 00:27:29 UTC (rev 185891)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js 2015-06-24 00:29:11 UTC (rev 185892)
@@ -105,11 +105,11 @@
consoleLogVisibilityChanged(visible)
{
- if (visible)
- this.element.classList.add(WebInspector.QuickConsole.ShowingLogClassName);
- else
- this.element.classList.remove(WebInspector.QuickConsole.ShowingLogClassName);
+ if (visible === this.element.classList.contains(WebInspector.QuickConsole.ShowingLogClassName))
+ return;
+ this.element.classList.toggle(WebInspector.QuickConsole.ShowingLogClassName, visible);
+
this.dispatchEventToListeners(WebInspector.QuickConsole.Event.DidResize);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
