[webkit-changes] [186174] trunk/Source/WebKit2

[commit-queue]

Title: [186174] trunk/Source/WebKit2

Revision

186174

Author

commit-qu...@webkit.org

Date

2015-07-01 01:55:02 -0700 (Wed, 01 Jul 2015)

Log Message

[Mac] Numerous CGColor leaks in swipe gestures
https://bugs.webkit.org/show_bug.cgi?id=146501

Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-07-01
Reviewed by Tim Horton.

* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::beginSwipeGesture):

Modified Paths

• trunk/Source/WebKit2/ChangeLog
• trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm

Diff

Modified: trunk/Source/WebKit2/ChangeLog (186173 => 186174)

--- trunk/Source/WebKit2/ChangeLog	2015-07-01 08:51:40 UTC (rev 186173)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-01 08:55:02 UTC (rev 186174)
@@ -1,5 +1,15 @@
 2015-07-01  Joseph Pecoraro  <pecor...@apple.com>
 
+        [Mac] Numerous CGColor leaks in swipe gestures
+        https://bugs.webkit.org/show_bug.cgi?id=146501
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/mac/ViewGestureControllerMac.mm:
+        (WebKit::ViewGestureController::beginSwipeGesture):
+
+2015-07-01  Joseph Pecoraro  <pecor...@apple.com>
+
         [Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
         https://bugs.webkit.org/show_bug.cgi?id=146503
 

Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm (186173 => 186174)

--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm	2015-07-01 08:51:40 UTC (rev 186173)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm	2015-07-01 08:55:02 UTC (rev 186174)
@@ -637,22 +637,22 @@
         m_swipeShadowLayer = adoptNS([[CAGradientLayer alloc] init]);
         [m_swipeShadowLayer setName:@"Gesture Swipe Shadow Layer"];
         [m_swipeShadowLayer setColors:@[
-            (id)CGColorCreateGenericGray(0, 1.),
-            (id)CGColorCreateGenericGray(0, 0.99),
-            (id)CGColorCreateGenericGray(0, 0.98),
-            (id)CGColorCreateGenericGray(0, 0.95),
-            (id)CGColorCreateGenericGray(0, 0.92),
-            (id)CGColorCreateGenericGray(0, 0.82),
-            (id)CGColorCreateGenericGray(0, 0.71),
-            (id)CGColorCreateGenericGray(0, 0.46),
-            (id)CGColorCreateGenericGray(0, 0.35),
-            (id)CGColorCreateGenericGray(0, 0.25),
-            (id)CGColorCreateGenericGray(0, 0.17),
-            (id)CGColorCreateGenericGray(0, 0.11),
-            (id)CGColorCreateGenericGray(0, 0.07),
-            (id)CGColorCreateGenericGray(0, 0.04),
-            (id)CGColorCreateGenericGray(0, 0.01),
-            (id)CGColorCreateGenericGray(0, 0.),
+            (id)adoptCF(CGColorCreateGenericGray(0, 1.)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.99)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.98)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.95)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.92)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.82)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.71)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.46)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.35)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.25)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.17)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.11)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.07)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.04)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.01)).get(),
+            (id)adoptCF(CGColorCreateGenericGray(0, 0.)).get(),
         ]];
         [m_swipeShadowLayer setLocations:@[
             @0,

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes