Title: [186625] branches/safari-600.8-branch/Source/WebCore
Revision
186625
Author
matthew_han...@apple.com
Date
2015-07-09 14:03:13 -0700 (Thu, 09 Jul 2015)

Log Message

Merge r186558. rdar://problem/21716436

Modified Paths

Diff

Modified: branches/safari-600.8-branch/Source/WebCore/ChangeLog (186624 => 186625)


--- branches/safari-600.8-branch/Source/WebCore/ChangeLog	2015-07-09 21:03:10 UTC (rev 186624)
+++ branches/safari-600.8-branch/Source/WebCore/ChangeLog	2015-07-09 21:03:13 UTC (rev 186625)
@@ -1,5 +1,27 @@
 2015-07-09  Matthew Hanson  <matthew_han...@apple.com>
 
+        Merge r186558. rdar://problem/21716436
+
+    2015-07-08  Matthew Hanson  <matthew_han...@apple.com>
+
+            Merge r183838. rdar://problem/21716569
+
+        2015-05-05  Joseph Pecoraro  <pecor...@apple.com>
+
+                Web Inspector: Crash under WebCore::domWindowFromExecState reloading page with inspector open
+                https://bugs.webkit.org/show_bug.cgi?id=144636
+
+                Reviewed by Mark Lam.
+
+                This ensures we create an InjectedScript for the execution context
+                (frame) preventing the global object / exec state from getting garbage
+                collected before we remove it from our map.
+
+                * inspector/PageRuntimeAgent.cpp:
+                (WebCore::PageRuntimeAgent::notifyContextCreated):
+
+2015-07-09  Matthew Hanson  <matthew_han...@apple.com>
+
         Merge r186557. rdar://problem/21716382
 
     2015-07-08  Matthew Hanson  <matthew_han...@apple.com>

Modified: branches/safari-600.8-branch/Source/WebCore/inspector/PageRuntimeAgent.cpp (186624 => 186625)


--- branches/safari-600.8-branch/Source/WebCore/inspector/PageRuntimeAgent.cpp	2015-07-09 21:03:10 UTC (rev 186624)
+++ branches/safari-600.8-branch/Source/WebCore/inspector/PageRuntimeAgent.cpp	2015-07-09 21:03:13 UTC (rev 186625)
@@ -174,8 +174,13 @@
 void PageRuntimeAgent::notifyContextCreated(const String& frameId, JSC::ExecState* scriptState, SecurityOrigin* securityOrigin, bool isPageContext)
 {
     ASSERT(securityOrigin || isPageContext);
+
+    InjectedScript result = injectedScriptManager()->injectedScriptFor(scriptState);
+    if (result.hasNoValue())
+        return;
+
     int executionContextId = injectedScriptManager()->injectedScriptIdFor(scriptState);
-    String name = securityOrigin ? securityOrigin->toRawString() : "";
+    String name = securityOrigin ? securityOrigin->toRawString() : String();
     m_frontendDispatcher->executionContextCreated(ExecutionContextDescription::create()
         .setId(executionContextId)
         .setIsPageContext(isPageContext)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to