Title: [186651] trunk/Source/WebInspectorUI
- Revision
- 186651
- Author
- timo...@apple.com
- Date
- 2015-07-09 17:02:41 -0700 (Thu, 09 Jul 2015)
Log Message
Web Inspector: Make the TabBar work better with AX
https://bugs.webkit.org/show_bug.cgi?id=146806
Reviewed by Joseph Pecoraro.
* UserInterface/Views/TabBar.js:
(WebInspector.TabBar): Set role to tablist and drop tabIndex.
* UserInterface/Views/TabBarItem.js:
(WebInspector.TabBarItem): Set role to tab and tabIndex.
(WebInspector.TabBarItem.prototype.set selected): Toggle aria-selected.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (186650 => 186651)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-09 23:43:08 UTC (rev 186650)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-10 00:02:41 UTC (rev 186651)
@@ -1,3 +1,16 @@
+2015-07-09 Timothy Hatcher <timo...@apple.com>
+
+ Web Inspector: Make the TabBar work better with AX
+ https://bugs.webkit.org/show_bug.cgi?id=146806
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/TabBar.js:
+ (WebInspector.TabBar): Set role to tablist and drop tabIndex.
+ * UserInterface/Views/TabBarItem.js:
+ (WebInspector.TabBarItem): Set role to tab and tabIndex.
+ (WebInspector.TabBarItem.prototype.set selected): Toggle aria-selected.
+
2015-07-09 Devin Rousso <drou...@apple.com>
Web Inspector: Don't clear the console when navigating to a different page
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js (186650 => 186651)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2015-07-09 23:43:08 UTC (rev 186650)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2015-07-10 00:02:41 UTC (rev 186651)
@@ -31,7 +31,7 @@
this._element = element || document.createElement("div");
this._element.classList.add("tab-bar");
- this._element.tabIndex = 0;
+ this._element.setAttribute("role", "tablist");
var topBorderElement = document.createElement("div");
topBorderElement.classList.add("top-border");
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js (186650 => 186651)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js 2015-07-09 23:43:08 UTC (rev 186650)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBarItem.js 2015-07-10 00:02:41 UTC (rev 186651)
@@ -33,6 +33,8 @@
this._element = document.createElement("div");
this._element.classList.add(WebInspector.TabBarItem.StyleClassName);
+ this._element.setAttribute("role", "tab");
+ this._element.tabIndex = 0;
if (pinned)
this._element.classList.add("pinned");
this._element[WebInspector.TabBarItem.ElementReferenceSymbol] = this;
@@ -100,6 +102,11 @@
set selected(selected)
{
this._element.classList.toggle("selected", selected);
+
+ if (selected)
+ this._element.setAttribute("aria-selected", "true");
+ else
+ this._element.removeAttribute("aria-selected");
}
get disabled()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
