Title: [187130] trunk/Source/WebCore
- Revision
- 187130
- Author
- jhoneyc...@apple.com
- Date
- 2015-07-21 15:34:27 -0700 (Tue, 21 Jul 2015)
Log Message
[iOS] Keyboard bold/italic/underline keys don't highlight after being
tapped to style a selection
https://bugs.webkit.org/show_bug.cgi?id=147164
<rdar://problem/21630806>
Reviewed by Ryosuke Niwa.
* editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::styleForSelectionStart):
Use adjustedSelectionStartForStyleComputation(), which will ensure that
we're at the start of the selected node, not at the end of the node
before the selection.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (187129 => 187130)
--- trunk/Source/WebCore/ChangeLog 2015-07-21 22:33:53 UTC (rev 187129)
+++ trunk/Source/WebCore/ChangeLog 2015-07-21 22:34:27 UTC (rev 187130)
@@ -1,3 +1,18 @@
+2015-07-21 Jon Honeycutt <jhoneyc...@apple.com>
+
+ [iOS] Keyboard bold/italic/underline keys don't highlight after being
+ tapped to style a selection
+ https://bugs.webkit.org/show_bug.cgi?id=147164
+ <rdar://problem/21630806>
+
+ Reviewed by Ryosuke Niwa.
+
+ * editing/cocoa/EditorCocoa.mm:
+ (WebCore::Editor::styleForSelectionStart):
+ Use adjustedSelectionStartForStyleComputation(), which will ensure that
+ we're at the start of the selected node, not at the end of the node
+ before the selection.
+
2015-07-21 Tim Horton <timothy_hor...@apple.com>
Placing video in fullscreen caused WebKit crash at WebCore::Range::textQuads
Modified: trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm (187129 => 187130)
--- trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm 2015-07-21 22:33:53 UTC (rev 187129)
+++ trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm 2015-07-21 22:34:27 UTC (rev 187130)
@@ -36,6 +36,7 @@
#import "RenderStyle.h"
#import "SoftLinking.h"
#import "Text.h"
+#import "htmlediting.h"
namespace WebCore {
@@ -47,7 +48,7 @@
if (frame->selection().isNone())
return nullptr;
- Position position = frame->selection().selection().visibleStart().deepEquivalent();
+ Position position = adjustedSelectionStartForStyleComputation(frame->selection().selection());
if (!position.isCandidate() || position.isNull())
return nullptr;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
