Title: [187624] trunk/Tools
- Revision
- 187624
- Author
- ander...@apple.com
- Date
- 2015-07-30 16:51:29 -0700 (Thu, 30 Jul 2015)
Log Message
Add support for window.open to WK1BrowserWindowController
https://bugs.webkit.org/show_bug.cgi?id=147474
Reviewed by Dan Bernstein.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
Set _javascript_CanOpenWindowsAutomatically to YES.
If this becomes a nuisance, we can always add a menu item to toggle this.
(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
Implement this UI delegate method.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (187623 => 187624)
--- trunk/Tools/ChangeLog 2015-07-30 23:47:57 UTC (rev 187623)
+++ trunk/Tools/ChangeLog 2015-07-30 23:51:29 UTC (rev 187624)
@@ -1,5 +1,20 @@
2015-07-30 Anders Carlsson <ander...@apple.com>
+ Add support for window.open to WK1BrowserWindowController
+ https://bugs.webkit.org/show_bug.cgi?id=147474
+
+ Reviewed by Dan Bernstein.
+
+ * MiniBrowser/mac/WK1BrowserWindowController.m:
+ (-[WK1BrowserWindowController awakeFromNib]):
+ Set _javascript_CanOpenWindowsAutomatically to YES.
+ If this becomes a nuisance, we can always add a menu item to toggle this.
+
+ (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
+ Implement this UI delegate method.
+
+2015-07-30 Anders Carlsson <ander...@apple.com>
+
Undo stray commit.
* MiniBrowser/mac/WK1BrowserWindowController.m:
Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (187623 => 187624)
--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:47:57 UTC (rev 187623)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:51:29 UTC (rev 187624)
@@ -52,6 +52,7 @@
[[WebPreferences standardPreferences] setDeveloperExtrasEnabled:YES];
[[WebPreferences standardPreferences] setImageControlsEnabled:YES];
[[WebPreferences standardPreferences] setServiceControlsEnabled:YES];
+ [[WebPreferences standardPreferences] setJavaScriptCanOpenWindowsAutomatically:YES];
[_webView _listenForLayoutMilestones:WebDidFirstLayout | WebDidFirstVisuallyNonEmptyLayout | WebDidHitRelevantRepaintedObjectsAreaThreshold];
@@ -312,6 +313,14 @@
[self.window setTitle:[title stringByAppendingString:@" [WK1]"]];
}
+- (WebView *)webView:(WebView *)sender createWebViewWithRequest:(NSURLRequest *)request
+{
+ WK1BrowserWindowController *newBrowserWindowController = [[WK1BrowserWindowController alloc] initWithWindowNibName:@"BrowserWindow"];
+ [newBrowserWindowController.window makeKeyAndOrderFront:self];
+
+ return newBrowserWindowController->_webView;
+}
+
- (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame
{
if (frame != [sender mainFrame])
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
