Title: [190655] trunk/Source/WebCore
- Revision
- 190655
- Author
- jer.no...@apple.com
- Date
- 2015-10-06 18:24:54 -0700 (Tue, 06 Oct 2015)
Log Message
[Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
https://bugs.webkit.org/show_bug.cgi?id=149845
Reviewed by Darin Adler.
When converting from time-as-double to MediaTime, a regression was introduced
when checking whether m_seekTo was set to a valid value or not. The clause
`time != -1` should be translated to `time.isValid()`, not `!time.isValid()`.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (190654 => 190655)
--- trunk/Source/WebCore/ChangeLog 2015-10-07 01:12:54 UTC (rev 190654)
+++ trunk/Source/WebCore/ChangeLog 2015-10-07 01:24:54 UTC (rev 190655)
@@ -1,3 +1,17 @@
+2015-10-06 Jer Noble <jer.no...@apple.com>
+
+ [Mac] REGRESSION(r173318): Seeks never complete for media loaded with QTKit.
+ https://bugs.webkit.org/show_bug.cgi?id=149845
+
+ Reviewed by Darin Adler.
+
+ When converting from time-as-double to MediaTime, a regression was introduced
+ when checking whether m_seekTo was set to a valid value or not. The clause
+ `time != -1` should be translated to `time.isValid()`, not `!time.isValid()`.
+
+ * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+ (WebCore::MediaPlayerPrivateQTKit::timeChanged):
+
2015-10-06 Brady Eidson <beid...@apple.com>
Rename IDBRequestIdentifier to IDBResourceIdentifier.
Modified: trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm (190654 => 190655)
--- trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm 2015-10-07 01:12:54 UTC (rev 190654)
+++ trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm 2015-10-07 01:24:54 UTC (rev 190655)
@@ -1113,7 +1113,7 @@
// It may not be possible to seek to a specific time in a streamed movie. When seeking in a
// stream QuickTime sets the movie time to closest time possible and posts a timechanged
// notification. Update m_seekTo so we can detect when the seek completes.
- if (!m_seekTo.isValid())
+ if (m_seekTo.isValid())
m_seekTo = currentMediaTime();
m_timeToRestore = MediaTime::invalidTime();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
