Diff
Modified: trunk/Source/WebCore/ChangeLog (192377 => 192378)
--- trunk/Source/WebCore/ChangeLog 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebCore/ChangeLog 2015-11-12 21:02:00 UTC (rev 192378)
@@ -1,3 +1,15 @@
+2015-11-12 Anders Carlsson <ander...@apple.com>
+
+ Remove an unused function
+ https://bugs.webkit.org/show_bug.cgi?id=151215
+
+ Reviewed by Joseph Pecoraro.
+
+ * loader/EmptyClients.h:
+ * page/ContextMenuClient.h:
+ * page/ContextMenuController.cpp:
+ (WebCore::ContextMenuController::contextMenuItemSelected): Deleted.
+
2015-11-11 Anders Carlsson <ander...@apple.com>
Enable cross-platform context menus by default
Modified: trunk/Source/WebCore/loader/EmptyClients.h (192377 => 192378)
--- trunk/Source/WebCore/loader/EmptyClients.h 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2015-11-12 21:02:00 UTC (rev 192378)
@@ -549,8 +549,6 @@
virtual ~EmptyContextMenuClient() { }
virtual void contextMenuDestroyed() override { }
- virtual void contextMenuItemSelected(ContextMenuItem*, const ContextMenu*) override { }
-
virtual void downloadURL(const URL&) override { }
virtual void searchWithGoogle(const Frame*) override { }
virtual void lookUpInDictionary(Frame*) override { }
Modified: trunk/Source/WebCore/page/ContextMenuClient.h (192377 => 192378)
--- trunk/Source/WebCore/page/ContextMenuClient.h 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebCore/page/ContextMenuClient.h 2015-11-12 21:02:00 UTC (rev 192378)
@@ -43,8 +43,6 @@
virtual ~ContextMenuClient() { }
virtual void contextMenuDestroyed() = 0;
- virtual void contextMenuItemSelected(ContextMenuItem*, const ContextMenu*) = 0;
-
virtual void downloadURL(const URL& url) = 0;
virtual void searchWithGoogle(const Frame*) = 0;
virtual void lookUpInDictionary(Frame*) = 0;
Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (192377 => 192378)
--- trunk/Source/WebCore/page/ContextMenuController.cpp 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebCore/page/ContextMenuController.cpp 2015-11-12 21:02:00 UTC (rev 192378)
@@ -215,11 +215,6 @@
{
ASSERT(item->type() == ActionType || item->type() == CheckableActionType);
- if (item->action() >= ContextMenuItemBaseApplicationTag) {
- m_client.contextMenuItemSelected(item, m_contextMenu.get());
- return;
- }
-
if (item->action() >= ContextMenuItemBaseCustomTag) {
ASSERT(m_menuProvider);
m_menuProvider->contextMenuItemSelected(item);
Modified: trunk/Source/WebKit/mac/ChangeLog (192377 => 192378)
--- trunk/Source/WebKit/mac/ChangeLog 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-11-12 21:02:00 UTC (rev 192378)
@@ -1,3 +1,14 @@
+2015-11-12 Anders Carlsson <ander...@apple.com>
+
+ Remove an unused function
+ https://bugs.webkit.org/show_bug.cgi?id=151215
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebContextMenuClient.h:
+ * WebCoreSupport/WebContextMenuClient.mm:
+ (WebContextMenuClient::contextMenuItemSelected): Deleted.
+
2015-11-11 Anders Carlsson <ander...@apple.com>
Enable cross-platform context menus by default
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h (192377 => 192378)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h 2015-11-12 21:02:00 UTC (rev 192378)
@@ -49,9 +49,7 @@
virtual ~WebContextMenuClient();
virtual void contextMenuDestroyed() override;
-
- virtual void contextMenuItemSelected(WebCore::ContextMenuItem*, const WebCore::ContextMenu*) override;
-
+
virtual void downloadURL(const WebCore::URL&) override;
virtual void searchWithGoogle(const WebCore::Frame*) override;
virtual void lookUpInDictionary(WebCore::Frame*) override;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm (192377 => 192378)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm 2015-11-12 21:02:00 UTC (rev 192378)
@@ -89,10 +89,6 @@
delete this;
}
-void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu)
-{
-}
-
void WebContextMenuClient::downloadURL(const URL& url)
{
[m_webView _downloadURL:url];
Modified: trunk/Source/WebKit/win/ChangeLog (192377 => 192378)
--- trunk/Source/WebKit/win/ChangeLog 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit/win/ChangeLog 2015-11-12 21:02:00 UTC (rev 192378)
@@ -1,3 +1,14 @@
+2015-11-12 Anders Carlsson <ander...@apple.com>
+
+ Remove an unused function
+ https://bugs.webkit.org/show_bug.cgi?id=151215
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebCoreSupport/WebContextMenuClient.cpp:
+ (WebContextMenuClient::contextMenuItemSelected): Deleted.
+ * WebCoreSupport/WebContextMenuClient.h:
+
2015-11-11 Geoffrey Garen <gga...@apple.com>
Rename handle.*Event to dispatch.*Event
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp (192377 => 192378)
--- trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp 2015-11-12 21:02:00 UTC (rev 192378)
@@ -52,10 +52,6 @@
delete this;
}
-void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem*, const ContextMenu*)
-{
-}
-
void WebContextMenuClient::downloadURL(const URL& url)
{
m_webView->downloadURL(url);
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.h (192377 => 192378)
--- trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.h 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebContextMenuClient.h 2015-11-12 21:02:00 UTC (rev 192378)
@@ -35,8 +35,6 @@
virtual void contextMenuDestroyed();
- virtual void contextMenuItemSelected(WebCore::ContextMenuItem*, const WebCore::ContextMenu*);
-
virtual void downloadURL(const WebCore::URL&);
virtual void searchWithGoogle(const WebCore::Frame*);
virtual void lookUpInDictionary(WebCore::Frame*);
Modified: trunk/Source/WebKit2/ChangeLog (192377 => 192378)
--- trunk/Source/WebKit2/ChangeLog 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit2/ChangeLog 2015-11-12 21:02:00 UTC (rev 192378)
@@ -1,3 +1,14 @@
+2015-11-12 Anders Carlsson <ander...@apple.com>
+
+ Remove an unused function
+ https://bugs.webkit.org/show_bug.cgi?id=151215
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
+ (WebKit::WebContextMenuClient::contextMenuItemSelected): Deleted.
+ * WebProcess/WebCoreSupport/WebContextMenuClient.h:
+
2015-11-11 Anders Carlsson <ander...@apple.com>
Enable cross-platform context menus by default
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp (192377 => 192378)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp 2015-11-12 21:02:00 UTC (rev 192378)
@@ -49,11 +49,6 @@
delete this;
}
-void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem*, const ContextMenu*)
-{
- notImplemented();
-}
-
void WebContextMenuClient::downloadURL(const URL&)
{
// This is handled in the UI process.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h (192377 => 192378)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h 2015-11-12 20:41:06 UTC (rev 192377)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.h 2015-11-12 21:02:00 UTC (rev 192378)
@@ -44,8 +44,6 @@
private:
virtual void contextMenuDestroyed() override;
- virtual void contextMenuItemSelected(WebCore::ContextMenuItem*, const WebCore::ContextMenu*) override;
-
virtual void downloadURL(const WebCore::URL&) override;
virtual void searchWithGoogle(const WebCore::Frame*) override;
virtual void lookUpInDictionary(WebCore::Frame*) override;
