[webkit-changes] [192520] trunk/Source/JavaScriptCore

[commit-queue]

Title: [192520] trunk/Source/_javascript_Core

Revision

192520

Author

commit-qu...@webkit.org

Date

2015-11-17 11:56:01 -0800 (Tue, 17 Nov 2015)

Log Message

Removed useless variable scriptResult from testExecutionTimeLimit
https://bugs.webkit.org/show_bug.cgi?id=151331

Patch by Matthew Daiter <mdaiter8...@gmail.com> on 2015-11-17
Reviewed by Alex Christensen.

* API/tests/ExecutionTimeLimitTest.cpp: Removed scriptResult
(testExecutionTimeLimit):

Modified Paths

• trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp
• trunk/Source/_javascript_Core/ChangeLog

Diff

Modified: trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp (192519 => 192520)

--- trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp	2015-11-17 19:41:27 UTC (rev 192519)
+++ trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp	2015-11-17 19:56:01 UTC (rev 192520)
@@ -128,7 +128,6 @@
         JSObjectRef globalObject = JSContextGetGlobalObject(context);
         ASSERT(JSValueIsObject(context, globalObject));
 
-        JSValueRef scriptResult = nullptr;
         JSValueRef exception = nullptr;
 
         JSStringRef currentCPUTimeStr = JSStringCreateWithUTF8CString("currentCPUTime");
@@ -151,7 +150,7 @@
             exception = nullptr;
             shouldTerminateCallbackWasCalled = false;
             auto startTime = currentCPUTime();
-            scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
+            JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
             auto endTime = currentCPUTime();
 
             if (((endTime - startTime) < milliseconds(timeAfterWatchdogShouldHaveFired)) && shouldTerminateCallbackWasCalled)
@@ -188,7 +187,7 @@
             shouldTerminateCallbackWasCalled = false;
 
             auto startTime = currentCPUTime();
-            scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
+            JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
             auto endTime = currentCPUTime();
             
             if (((endTime - startTime) >= milliseconds(timeAfterWatchdogShouldHaveFired)) || !shouldTerminateCallbackWasCalled) {
@@ -225,7 +224,7 @@
             shouldTerminateCallbackWasCalled = false;
 
             auto startTime = currentCPUTime();
-            scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
+            JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
             auto endTime = currentCPUTime();
             
             if (((endTime - startTime) < milliseconds(timeAfterWatchdogShouldHaveFired)) && !shouldTerminateCallbackWasCalled)
@@ -262,7 +261,7 @@
             cancelTerminateCallbackWasCalled = false;
 
             auto startTime = currentCPUTime();
-            scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
+            JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
             auto endTime = currentCPUTime();
             
             if (((endTime - startTime) >= milliseconds(timeAfterWatchdogShouldHaveFired)) && cancelTerminateCallbackWasCalled && !exception)
@@ -299,7 +298,7 @@
             extendTerminateCallbackCalled = 0;
 
             auto startTime = currentCPUTime();
-            scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
+            JSEvaluateScript(context, script, nullptr, nullptr, 1, &exception);
             auto endTime = currentCPUTime();
             auto deltaTime = endTime - startTime;
             

Modified: trunk/Source/_javascript_Core/ChangeLog (192519 => 192520)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:41:27 UTC (rev 192519)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:56:01 UTC (rev 192520)
@@ -1,3 +1,13 @@
+2015-11-17  Matthew Daiter  <mdaiter8...@gmail.com>
+
+        Removed useless variable scriptResult from testExecutionTimeLimit
+        https://bugs.webkit.org/show_bug.cgi?id=151331
+
+        Reviewed by Alex Christensen.
+
+        * API/tests/ExecutionTimeLimitTest.cpp: Removed scriptResult
+        (testExecutionTimeLimit):
+
 2015-11-16  Mark Lam  <mark....@apple.com>
 
         [JSC] Support Doubles with B3's Sub.

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes