Title: [193427] trunk
- Revision
- 193427
- Author
- joep...@webkit.org
- Date
- 2015-12-04 10:50:10 -0800 (Fri, 04 Dec 2015)
Log Message
Web Inspector: Unskip many inspector/debugger tests
https://bugs.webkit.org/show_bug.cgi?id=151843
Reviewed by Timothy Hatcher.
Source/_javascript_Core:
* bindings/ScriptFunctionCall.cpp:
(Deprecated::ScriptFunctionCall::call):
Ignore TerminationExceptions, as those aren't real execution
exceptions and may be seen on Workers that have closed.
LayoutTests:
* TestExpectations:
* platform/mac/TestExpectations:
Skip specific tests.
* platform/mac-wk2/TestExpectations:
Test no longer existed.
* inspector/debugger/resources/exception.js:
(exceptionDOM):
Keep the code outputing a NotFoundException. This particular
invocation was recently changed to throw a TypeError.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (193426 => 193427)
--- trunk/LayoutTests/ChangeLog 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/ChangeLog 2015-12-04 18:50:10 UTC (rev 193427)
@@ -1,5 +1,24 @@
2015-12-04 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Unskip many inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=151843
+
+ Reviewed by Timothy Hatcher.
+
+ * TestExpectations:
+ * platform/mac/TestExpectations:
+ Skip specific tests.
+
+ * platform/mac-wk2/TestExpectations:
+ Test no longer existed.
+
+ * inspector/debugger/resources/exception.js:
+ (exceptionDOM):
+ Keep the code outputing a NotFoundException. This particular
+ invocation was recently changed to throw a TypeError.
+
+2015-12-04 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Remove untested and unused Worker inspection
https://bugs.webkit.org/show_bug.cgi?id=151848
Modified: trunk/LayoutTests/TestExpectations (193426 => 193427)
--- trunk/LayoutTests/TestExpectations 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/TestExpectations 2015-12-04 18:50:10 UTC (rev 193427)
@@ -126,7 +126,6 @@
webkit.org/b/129639 inspector/dom/dom-search-crash.html [ Skip ]
-webkit.org/b/133761 inspector/debugger/breakpoint-action-detach.html [ Skip ]
webkit.org/b/147502 inspector/debugger/break-on-uncaught-exception-throw-in-promise-rethrow-in-catch.html [ Skip ]
webkit.org/b/147502 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then-with-catch.html [ Skip ]
webkit.org/b/147502 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then.html [ Skip ]
Modified: trunk/LayoutTests/inspector/debugger/resources/exception.js (193426 => 193427)
--- trunk/LayoutTests/inspector/debugger/resources/exception.js 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/inspector/debugger/resources/exception.js 2015-12-04 18:50:10 UTC (rev 193427)
@@ -5,7 +5,7 @@
function exceptionDOM()
{
- document.body.appendChild(0);
+ document.body.removeChild(document.createElement("span"));
}
function throwString()
Modified: trunk/LayoutTests/platform/mac/TestExpectations (193426 => 193427)
--- trunk/LayoutTests/platform/mac/TestExpectations 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-12-04 18:50:10 UTC (rev 193427)
@@ -743,9 +743,16 @@
webkit.org/b/123369 svg/css/parent-shadow-offscreen.svg [ ImageOnlyFailure ]
webkit.org/b/123369 svg/css/root-shadow-offscreen.svg [ ImageOnlyFailure ]
-# webkit.org/b/100846, webkit.org/b/136715, webkit.org/b/148642, webkit.org/b/148654
-inspector/debugger
-inspector/dom-debugger/node-removed.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-rethrow-in-catch.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then-with-catch.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-then.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise-with-catch.html
+webkit.org/b/151832 inspector/debugger/break-on-uncaught-exception-throw-in-promise.html
+inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html
+inspector/debugger/didSampleProbe-multiple-probes.html
+inspector/debugger/nested-inspectors.html
+inspector/debugger/pause-reason.html
+inspector/debugger/regress-133182.html
webkit.org/b/124311 compositing/regions/transform-transparent-positioned-video-inside-region.html [ ImageOnlyFailure ]
Modified: trunk/Source/_javascript_Core/ChangeLog (193426 => 193427)
--- trunk/Source/_javascript_Core/ChangeLog 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-12-04 18:50:10 UTC (rev 193427)
@@ -1,5 +1,17 @@
2015-12-04 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Unskip many inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=151843
+
+ Reviewed by Timothy Hatcher.
+
+ * bindings/ScriptFunctionCall.cpp:
+ (Deprecated::ScriptFunctionCall::call):
+ Ignore TerminationExceptions, as those aren't real execution
+ exceptions and may be seen on Workers that have closed.
+
+2015-12-04 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Remove untested and unused Worker inspection
https://bugs.webkit.org/show_bug.cgi?id=151848
Modified: trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp (193426 => 193427)
--- trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp 2015-12-04 18:50:05 UTC (rev 193426)
+++ trunk/Source/_javascript_Core/bindings/ScriptFunctionCall.cpp 2015-12-04 18:50:10 UTC (rev 193427)
@@ -140,7 +140,8 @@
result = JSC::call(m_exec, function, callType, callData, thisObject, m_arguments, exception);
if (exception) {
- hadException = true;
+ // Do not treat a terminated execution exception as having an exception. Just treat it as an empty result.
+ hadException = !isTerminatedExecutionException(exception);
return Deprecated::ScriptValue();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
