Title: [193995] trunk
- Revision
- 193995
- Author
- a...@apple.com
- Date
- 2015-12-11 16:45:03 -0800 (Fri, 11 Dec 2015)
Log Message
Roll out http://trac.webkit.org/r193984, because the new test is timing out.
Was: Strip out Referer header when requesting subresources or following links for documents with "Content-Disposition: attachment"
https://bugs.webkit.org/show_bug.cgi?id=152102
<rdar://problem/22124230>
Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::processReferrerPolicy):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
LayoutTests:
* http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php: Removed.
* http/tests/contentdispositionattachmentsandbox/resources/subresource-request-not-include-referer-header-frame.php: Removed.
* http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header-expected.txt: Removed.
* http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (193994 => 193995)
--- trunk/LayoutTests/ChangeLog 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/LayoutTests/ChangeLog 2015-12-12 00:45:03 UTC (rev 193995)
@@ -1,3 +1,16 @@
+2015-12-11 Alexey Proskuryakov <a...@apple.com>
+
+ Roll out http://trac.webkit.org/r193984, because the new test is timing out.
+
+ Was: Strip out Referer header when requesting subresources or following links for documents with "Content-Disposition: attachment"
+ https://bugs.webkit.org/show_bug.cgi?id=152102
+ <rdar://problem/22124230>
+
+ * http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php: Removed.
+ * http/tests/contentdispositionattachmentsandbox/resources/subresource-request-not-include-referer-header-frame.php: Removed.
+ * http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header-expected.txt: Removed.
+ * http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html: Removed.
+
2015-12-11 Brady Eidson <beid...@apple.com>
Modern IDB: storage/indexeddb/optional-arguments.html fails.
Deleted: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php (193994 => 193995)
--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/echo-http-referer.php 2015-12-12 00:45:03 UTC (rev 193995)
@@ -1,8 +0,0 @@
-<!DOCTYPE html>
-<script>
-if (window.parent.testRunner)
- testRunner.notifyDone();
-</script>
-<?php
-echo $_SERVER['HTTP_REFERER'];
-?>
\ No newline at end of file
Deleted: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/subresource-request-not-include-referer-header-frame.php (193994 => 193995)
--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/subresource-request-not-include-referer-header-frame.php 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/subresource-request-not-include-referer-header-frame.php 2015-12-12 00:45:03 UTC (rev 193995)
@@ -1,14 +0,0 @@
-<?php
-header("Content-Disposition: attachment; filename=test.html");
-header("Content-Type: text/html");
-?>
-<!DOCTYPE html>
-<style>
-a {
- display: block;
- width: 100vw;
- height: 100vh;
-}
-
-</style>
-<a href="" to second-wo-referer.php</a>
\ No newline at end of file
Deleted: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header-expected.txt (193994 => 193995)
--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header-expected.txt 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header-expected.txt 2015-12-12 00:45:03 UTC (rev 193995)
@@ -1,8 +0,0 @@
-This test verifies that a subresource loaded by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.
-
-
-
---------
-Frame: 'iframe'
---------
-
Deleted: trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html (193994 => 193995)
--- trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/LayoutTests/http/tests/contentdispositionattachmentsandbox/subresource-request-not-include-referer-header.html 2015-12-12 00:45:03 UTC (rev 193995)
@@ -1,31 +0,0 @@
-<!DOCTYPE html>
-<script>
-if (window.internals)
- internals.settings.setContentDispositionAttachmentSandboxEnabled(true);
-
-if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.dumpChildFramesAsText();
- testRunner.waitUntilDone();
-}
-
-function navigation() {
- // Due to the sandbox, it's not possible to run script in the iframe or even access its contentDocument.
- var element = document.getElementById('iframe');
- var x = element.offsetLeft + 10;
- var y = element.offsetTop + 10;
-
- if (window.testRunner) {
- if (window.eventSender) {
- eventSender.mouseMoveTo(x, y);
- eventSender.mouseDown();
- eventSender.mouseUp();
- }
-
- if (testRunner.runUIScript)
- testRunner.runUIScript("(function() { uiController.singleTapAtPoint(" + x + ", " + y + "); })()");
- }
-}
-</script>
-<p>This test verifies that a subresource loaded by a document which is loaded with Content-Disposition:attachment will not have http referer. Tess passes if no referer is printed.</p>
-<iframe id='iframe' src="" _onload_="navigation()"></iframe>
Modified: trunk/Source/WebCore/ChangeLog (193994 => 193995)
--- trunk/Source/WebCore/ChangeLog 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/Source/WebCore/ChangeLog 2015-12-12 00:45:03 UTC (rev 193995)
@@ -1,3 +1,15 @@
+2015-12-11 Alexey Proskuryakov <a...@apple.com>
+
+ Roll out http://trac.webkit.org/r193984, because the new test is timing out.
+
+ Was: Strip out Referer header when requesting subresources or following links for documents with "Content-Disposition: attachment"
+ https://bugs.webkit.org/show_bug.cgi?id=152102
+ <rdar://problem/22124230>
+
+ * dom/Document.cpp:
+ (WebCore::Document::processReferrerPolicy):
+ (WebCore::Document::applyContentDispositionAttachmentSandbox):
+
2015-12-11 Brady Eidson <beid...@apple.com>
Modern IDB: storage/indexeddb/optional-arguments.html fails.
Modified: trunk/Source/WebCore/dom/Document.cpp (193994 => 193995)
--- trunk/Source/WebCore/dom/Document.cpp 2015-12-12 00:18:18 UTC (rev 193994)
+++ trunk/Source/WebCore/dom/Document.cpp 2015-12-12 00:45:03 UTC (rev 193995)
@@ -3339,11 +3339,6 @@
{
ASSERT(!policy.isNull());
- // Documents in a Content-Disposition: attachment sandbox should never send a Referer header,
- // even if the document has a meta tag saying otherwise.
- if (shouldEnforceContentDispositionAttachmentSandbox())
- return;
-
// Note that we're supporting both the standard and legacy keywords for referrer
// policies, as defined by http://www.w3.org/TR/referrer-policy/#referrer-policy-delivery-meta
if (equalIgnoringCase(policy, "no-referrer") || equalIgnoringCase(policy, "never"))
@@ -6876,7 +6871,6 @@
{
ASSERT(shouldEnforceContentDispositionAttachmentSandbox());
- setReferrerPolicy(ReferrerPolicyNever);
if (!isMediaDocument())
enforceSandboxFlags(SandboxAll);
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
