Title: [195444] trunk/Tools
- Revision
- 195444
- Author
- simon.fra...@apple.com
- Date
- 2016-01-21 22:44:52 -0800 (Thu, 21 Jan 2016)
Log Message
Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
https://bugs.webkit.org/show_bug.cgi?id=153334
Reviewed by Zalan Bujtas.
Evaluating expressions in the LayoutUnit summary provider seems to cause
re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
denominator to 64.
* lldb/lldb_webkit.py:
(WebCoreLayoutUnitProvider.to_string):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (195443 => 195444)
--- trunk/Tools/ChangeLog 2016-01-22 06:39:57 UTC (rev 195443)
+++ trunk/Tools/ChangeLog 2016-01-22 06:44:52 UTC (rev 195444)
@@ -1,3 +1,17 @@
+2016-01-21 Simon Fraser <simon.fra...@apple.com>
+
+ Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
+ https://bugs.webkit.org/show_bug.cgi?id=153334
+
+ Reviewed by Zalan Bujtas.
+
+ Evaluating expressions in the LayoutUnit summary provider seems to cause
+ re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
+ denominator to 64.
+
+ * lldb/lldb_webkit.py:
+ (WebCoreLayoutUnitProvider.to_string):
+
2016-01-21 Filip Pizlo <fpi...@apple.com>
display-profiler-output should be able to display code blocks sorted by machine counts
Modified: trunk/Tools/lldb/lldb_webkit.py (195443 => 195444)
--- trunk/Tools/lldb/lldb_webkit.py 2016-01-22 06:39:57 UTC (rev 195443)
+++ trunk/Tools/lldb/lldb_webkit.py 2016-01-22 06:44:52 UTC (rev 195444)
@@ -277,11 +277,7 @@
def to_string(self):
layoutUnitValue = self.valobj.GetChildMemberWithName('m_value').GetValueAsSigned(0)
- # figure out the layout unit denominator by checking infinite IntRect's value. It ensures that this function works even when subpixel is off.
- infiniteWidth = self.valobj.GetFrame().EvaluateExpression('IntRect::infiniteRect()').GetChildMemberWithName('m_size').GetChildMemberWithName('m_width').GetValueAsSigned(0)
- # denominator = maxint / current infinite width value
- denominator = int(2147483647 / infiniteWidth) if infiniteWidth else 64
- return "%gpx (%d)" % (float(layoutUnitValue) / denominator, layoutUnitValue)
+ return "%gpx (%d)" % (float(layoutUnitValue) / 64, layoutUnitValue)
class WebCoreLayoutSizeProvider:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
