Title: [196432] trunk/Source/_javascript_Core
- Revision
- 196432
- Author
- sbar...@apple.com
- Date
- 2016-02-11 13:04:43 -0800 (Thu, 11 Feb 2016)
Log Message
The sampling profiler's stack walker methods should be marked with SUPPRESS_ASAN
https://bugs.webkit.org/show_bug.cgi?id=154123
Reviewed by Mark Lam.
The entire premise of the sampling profiler is to load from
another thread's memory. We should SUPPRESS_ASAN on the
methods that do this.
* runtime/SamplingProfiler.cpp:
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::advanceToParentFrame):
(JSC::FrameWalker::isAtTop):
(JSC::FrameWalker::resetAtMachineFrame):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (196431 => 196432)
--- trunk/Source/_javascript_Core/ChangeLog 2016-02-11 20:50:07 UTC (rev 196431)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-02-11 21:04:43 UTC (rev 196432)
@@ -1,3 +1,21 @@
+2016-02-11 Saam barati <sbar...@apple.com>
+
+ The sampling profiler's stack walker methods should be marked with SUPPRESS_ASAN
+ https://bugs.webkit.org/show_bug.cgi?id=154123
+
+ Reviewed by Mark Lam.
+
+ The entire premise of the sampling profiler is to load from
+ another thread's memory. We should SUPPRESS_ASAN on the
+ methods that do this.
+
+ * runtime/SamplingProfiler.cpp:
+ (JSC::FrameWalker::FrameWalker):
+ (JSC::FrameWalker::walk):
+ (JSC::FrameWalker::advanceToParentFrame):
+ (JSC::FrameWalker::isAtTop):
+ (JSC::FrameWalker::resetAtMachineFrame):
+
2016-02-11 Csaba Osztrogonác <o...@webkit.org>
Unreviewed typo fix after r190063.
Modified: trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp (196431 => 196432)
--- trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp 2016-02-11 20:50:07 UTC (rev 196431)
+++ trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp 2016-02-11 21:04:43 UTC (rev 196432)
@@ -82,6 +82,7 @@
{
}
+ SUPPRESS_ASAN
size_t walk(Vector<UnprocessedStackFrame>& stackTrace, bool& didRunOutOfSpace)
{
if (sReportStats)
@@ -113,6 +114,7 @@
private:
+ SUPPRESS_ASAN
void advanceToParentFrame()
{
m_callFrame = m_callFrame->callerFrame(m_vmEntryFrame);
@@ -123,6 +125,7 @@
return !m_callFrame;
}
+ SUPPRESS_ASAN
void resetAtMachineFrame()
{
if (isAtTop())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
