Title: [197307] trunk
- Revision
- 197307
- Author
- cdu...@apple.com
- Date
- 2016-02-28 20:36:06 -0800 (Sun, 28 Feb 2016)
Log Message
Parse HTMLOLElement.start as per the HTML spec
https://bugs.webkit.org/show_bug.cgi?id=154802
Reviewed by Andreas Kling.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/reflection-grouping-expected.txt:
Source/WebCore:
Parse HTMLOLElement.start as per the HTML spec:
- https://html.spec.whatwg.org/multipage/semantics.html#dom-ol-start
- https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-integers
No new tests, already covered by existing test.
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::parseAttribute):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (197306 => 197307)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-29 04:36:06 UTC (rev 197307)
@@ -1,3 +1,14 @@
+2016-02-28 Chris Dumez <cdu...@apple.com>
+
+ Parse HTMLOLElement.start as per the HTML spec
+ https://bugs.webkit.org/show_bug.cgi?id=154802
+
+ Reviewed by Andreas Kling.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-grouping-expected.txt:
+
2016-02-27 Chris Dumez <cdu...@apple.com>
Align HTMLMarqueeElement.scrollAmount / scrollDelay with the specification
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt (197306 => 197307)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-grouping-expected.txt 2016-02-29 04:36:06 UTC (rev 197307)
@@ -4440,7 +4440,7 @@
PASS ol.start: setAttribute() to "\t7" followed by getAttribute()
PASS ol.start: setAttribute() to "\t7" followed by IDL get
PASS ol.start: setAttribute() to "\v7" followed by getAttribute()
-FAIL ol.start: setAttribute() to "\v7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to "\v7" followed by IDL get
PASS ol.start: setAttribute() to "\f7" followed by getAttribute()
PASS ol.start: setAttribute() to "\f7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
@@ -4454,39 +4454,39 @@
PASS ol.start: setAttribute() to "\r7" followed by getAttribute()
PASS ol.start: setAttribute() to "\r7" followed by IDL get
PASS ol.start: setAttribute() to "
7" followed by getAttribute()
-FAIL ol.start: setAttribute() to "
7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to "
7" followed by IDL get
PASS ol.start: setAttribute() to "
7" followed by getAttribute()
PASS ol.start: setAttribute() to "
7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to "7" followed by getAttribute()
PASS ol.start: setAttribute() to "7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to " 7" followed by getAttribute()
-FAIL ol.start: setAttribute() to " 7" followed by IDL get assert_equals: expected 1 but got 7
+PASS ol.start: setAttribute() to " 7" followed by IDL get
PASS ol.start: setAttribute() to undefined followed by getAttribute()
PASS ol.start: setAttribute() to undefined followed by IDL get
PASS ol.start: setAttribute() to 1.5 followed by getAttribute()
Modified: trunk/Source/WebCore/ChangeLog (197306 => 197307)
--- trunk/Source/WebCore/ChangeLog 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/Source/WebCore/ChangeLog 2016-02-29 04:36:06 UTC (rev 197307)
@@ -1,3 +1,19 @@
+2016-02-28 Chris Dumez <cdu...@apple.com>
+
+ Parse HTMLOLElement.start as per the HTML spec
+ https://bugs.webkit.org/show_bug.cgi?id=154802
+
+ Reviewed by Andreas Kling.
+
+ Parse HTMLOLElement.start as per the HTML spec:
+ - https://html.spec.whatwg.org/multipage/semantics.html#dom-ol-start
+ - https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-integers
+
+ No new tests, already covered by existing test.
+
+ * html/HTMLOListElement.cpp:
+ (WebCore::HTMLOListElement::parseAttribute):
+
2016-02-28 Gyuyoung Kim <gyuyoung....@webkit.org>
Reduce uses of PassRefPtr in indexeddb
Modified: trunk/Source/WebCore/html/HTMLOListElement.cpp (197306 => 197307)
--- trunk/Source/WebCore/html/HTMLOListElement.cpp 2016-02-29 01:57:41 UTC (rev 197306)
+++ trunk/Source/WebCore/html/HTMLOListElement.cpp 2016-02-29 04:36:06 UTC (rev 197307)
@@ -26,6 +26,7 @@
#include "CSSPropertyNames.h"
#include "CSSValueKeywords.h"
#include "HTMLNames.h"
+#include "HTMLParserIdioms.h"
#include "RenderListItem.h"
namespace WebCore {
@@ -81,10 +82,9 @@
{
if (name == startAttr) {
int oldStart = start();
- bool canParse;
- int parsedStart = value.toInt(&canParse);
- m_hasExplicitStart = canParse;
- m_start = canParse ? parsedStart : 0xBADBEEF;
+ m_hasExplicitStart = parseHTMLInteger(value, m_start);
+ if (!m_hasExplicitStart)
+ m_start = 0xBADBEEF;
if (oldStart == start())
return;
updateItemValues();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
