Title: [197630] trunk/Source/WebCore
- Revision
- 197630
- Author
- rn...@webkit.org
- Date
- 2016-03-05 20:25:32 -0800 (Sat, 05 Mar 2016)
Log Message
Minor cleans up in custom elements' code per Darin's comments
https://bugs.webkit.org/show_bug.cgi?id=155081
Reviewed by Darin Adler.
Cleanup per Darin's comments.
* dom/CustomElementDefinitions.cpp:
(WebCore::CustomElementDefinitions::findInterface): Use get instead of explicitly checking against end().
* dom/LifecycleCallbackQueue.h: Remove unecessary header includes.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (197629 => 197630)
--- trunk/Source/WebCore/ChangeLog 2016-03-06 04:18:54 UTC (rev 197629)
+++ trunk/Source/WebCore/ChangeLog 2016-03-06 04:25:32 UTC (rev 197630)
@@ -1,3 +1,16 @@
+2016-03-05 Ryosuke Niwa <rn...@webkit.org>
+
+ Minor cleans up in custom elements' code per Darin's comments
+ https://bugs.webkit.org/show_bug.cgi?id=155081
+
+ Reviewed by Darin Adler.
+
+ Cleanup per Darin's comments.
+
+ * dom/CustomElementDefinitions.cpp:
+ (WebCore::CustomElementDefinitions::findInterface): Use get instead of explicitly checking against end().
+ * dom/LifecycleCallbackQueue.h: Remove unecessary header includes.
+
2016-03-05 Sam Weinig <s...@webkit.org>
Fix two minor typos from http://trac.webkit.org/changeset/197626 that were causing some test failures.
Modified: trunk/Source/WebCore/dom/CustomElementDefinitions.cpp (197629 => 197630)
--- trunk/Source/WebCore/dom/CustomElementDefinitions.cpp 2016-03-06 04:18:54 UTC (rev 197629)
+++ trunk/Source/WebCore/dom/CustomElementDefinitions.cpp 2016-03-06 04:25:32 UTC (rev 197630)
@@ -85,14 +85,12 @@
JSCustomElementInterface* CustomElementDefinitions::findInterface(const AtomicString& name) const
{
- auto it = m_nameMap.find(name);
- return it == m_nameMap.end() ? nullptr : it->value.get();
+ return m_nameMap.get(name);
}
JSCustomElementInterface* CustomElementDefinitions::findInterface(const JSC::JSObject* constructor) const
{
- auto it = m_constructorMap.find(constructor);
- return it == m_constructorMap.end() ? nullptr : it->value;
+ return m_constructorMap.get(constructor);
}
bool CustomElementDefinitions::containsConstructor(const JSC::JSObject* constructor) const
Modified: trunk/Source/WebCore/dom/LifecycleCallbackQueue.h (197629 => 197630)
--- trunk/Source/WebCore/dom/LifecycleCallbackQueue.h 2016-03-06 04:18:54 UTC (rev 197629)
+++ trunk/Source/WebCore/dom/LifecycleCallbackQueue.h 2016-03-06 04:25:32 UTC (rev 197630)
@@ -28,18 +28,17 @@
#if ENABLE(CUSTOM_ELEMENTS)
+#include <wtf/Forward.h>
#include <wtf/Noncopyable.h>
-#include <wtf/RefCounted.h>
#include <wtf/Vector.h>
-#include <wtf/text/AtomicString.h>
namespace WebCore {
class JSCustomElementInterface;
class Document;
class Element;
-class QualifiedName;
class LifecycleQueueItem;
+class QualifiedName;
class LifecycleCallbackQueue {
WTF_MAKE_NONCOPYABLE(LifecycleCallbackQueue);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
