Title: [198427] trunk
- Revision
- 198427
- Author
- n_w...@apple.com
- Date
- 2016-03-18 10:48:14 -0700 (Fri, 18 Mar 2016)
Log Message
AX: AXARIACurrent exposed but not displayed in Accessibility Inspector
https://bugs.webkit.org/show_bug.cgi?id=155600
Reviewed by Chris Fleizach.
Source/WebCore:
AXARIACurrent attribute was added to a temporary array that was never returned.
Test: accessibility/mac/aria-current-attribute-exposed.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
* accessibility/mac/aria-current-attribute-exposed-expected.txt: Added.
* accessibility/mac/aria-current-attribute-exposed.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (198426 => 198427)
--- trunk/LayoutTests/ChangeLog 2016-03-18 17:44:00 UTC (rev 198426)
+++ trunk/LayoutTests/ChangeLog 2016-03-18 17:48:14 UTC (rev 198427)
@@ -1,5 +1,15 @@
2016-03-18 Nan Wang <n_w...@apple.com>
+ AX: AXARIACurrent exposed but not displayed in Accessibility Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=155600
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/aria-current-attribute-exposed-expected.txt: Added.
+ * accessibility/mac/aria-current-attribute-exposed.html: Added.
+
+2016-03-18 Nan Wang <n_w...@apple.com>
+
AX: Typing broken on form input field while using VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=155613
Added: trunk/LayoutTests/accessibility/mac/aria-current-attribute-exposed-expected.txt (0 => 198427)
--- trunk/LayoutTests/accessibility/mac/aria-current-attribute-exposed-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/mac/aria-current-attribute-exposed-expected.txt 2016-03-18 17:48:14 UTC (rev 198427)
@@ -0,0 +1,12 @@
+Link Current Link
+This tests that aria-current attribute is correctly exposed.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS link1.allAttributes().includes('AXARIACurrent: true') is false
+PASS link2.allAttributes().includes('AXARIACurrent: true') is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/accessibility/mac/aria-current-attribute-exposed.html (0 => 198427)
--- trunk/LayoutTests/accessibility/mac/aria-current-attribute-exposed.html (rev 0)
+++ trunk/LayoutTests/accessibility/mac/aria-current-attribute-exposed.html 2016-03-18 17:48:14 UTC (rev 198427)
@@ -0,0 +1,32 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+</head>
+<body>
+
+<div id="container">
+<a id="link1" href=""
+<a id="link2" aria-current="true" href="" Link</a>
+</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+ description("This tests that aria-current attribute is correctly exposed.");
+
+ if (window.accessibilityController) {
+ var link1 = accessibilityController.accessibleElementById("link1");
+ var link2 = accessibilityController.accessibleElementById("link2");
+
+ // Attributes of link1 shouldn't contain AXARIACurrent
+ shouldBeFalse("link1.allAttributes().includes('AXARIACurrent: true')");
+ // Attributes of link2 should contain AXARIACurrent
+ shouldBeTrue("link2.allAttributes().includes('AXARIACurrent: true')");
+ }
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (198426 => 198427)
--- trunk/Source/WebCore/ChangeLog 2016-03-18 17:44:00 UTC (rev 198426)
+++ trunk/Source/WebCore/ChangeLog 2016-03-18 17:48:14 UTC (rev 198427)
@@ -1,5 +1,19 @@
2016-03-18 Nan Wang <n_w...@apple.com>
+ AX: AXARIACurrent exposed but not displayed in Accessibility Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=155600
+
+ Reviewed by Chris Fleizach.
+
+ AXARIACurrent attribute was added to a temporary array that was never returned.
+
+ Test: accessibility/mac/aria-current-attribute-exposed.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+
+2016-03-18 Nan Wang <n_w...@apple.com>
+
AX: Typing broken on form input field while using VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=155613
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (198426 => 198427)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2016-03-18 17:44:00 UTC (rev 198426)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2016-03-18 17:48:14 UTC (rev 198427)
@@ -1895,7 +1895,7 @@
// Only expose AXARIACurrent attribute when the element is set to be current item.
if (m_object->ariaCurrentState() != ARIACurrentFalse)
- [objectAttributes arrayByAddingObjectsFromArray:@[ NSAccessibilityARIACurrentAttribute ]];
+ objectAttributes = [objectAttributes arrayByAddingObjectsFromArray:@[ NSAccessibilityARIACurrentAttribute ]];
return objectAttributes;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
