Title: [198732] trunk/Source/WebCore
Revision
198732
Author
r...@igalia.com
Date
2016-03-28 04:22:45 -0700 (Mon, 28 Mar 2016)

Log Message

[css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
https://bugs.webkit.org/show_bug.cgi?id=155788

Reviewed by Sergio Villar Senin.

Just remove 2 lines/variables that were not needed at all in
RenderGrid::offsetAndBreadthForPositionedChild().

No new tests, no change of behavior.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (198731 => 198732)


--- trunk/Source/WebCore/ChangeLog	2016-03-28 08:45:44 UTC (rev 198731)
+++ trunk/Source/WebCore/ChangeLog	2016-03-28 11:22:45 UTC (rev 198732)
@@ -1,3 +1,18 @@
+2016-03-28  Manuel Rego Casasnovas  <r...@igalia.com>
+
+        [css-grid] Remove unneeded lines in offsetAndBreadthForPositionedChild()
+        https://bugs.webkit.org/show_bug.cgi?id=155788
+
+        Reviewed by Sergio Villar Senin.
+
+        Just remove 2 lines/variables that were not needed at all in
+        RenderGrid::offsetAndBreadthForPositionedChild().
+
+        No new tests, no change of behavior.
+
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
+
 2016-03-27  Konstantin Tokarev  <annu...@yandex.ru>
 
         Removed redundant #if conditions in ANGLEWebKitBridge.h

Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (198731 => 198732)


--- trunk/Source/WebCore/rendering/RenderGrid.cpp	2016-03-28 08:45:44 UTC (rev 198731)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp	2016-03-28 11:22:45 UTC (rev 198732)
@@ -1517,12 +1517,9 @@
         || (endLine < firstExplicitLine)
         || (endLine > lastExplicitLine);
 
-    unsigned initialPosition = startIsAuto ? 0 : startLine;
-    unsigned finalPosition = endIsAuto ? lastExplicitLine : endLine;
+    LayoutUnit start = startIsAuto ? LayoutUnit() : (isRowAxis ?  m_columnPositions[startLine] : m_rowPositions[startLine]);
+    LayoutUnit end = endIsAuto ? (isRowAxis ? logicalWidth() : logicalHeight()) : (isRowAxis ?  m_columnPositions[endLine] : m_rowPositions[endLine]);
 
-    LayoutUnit start = startIsAuto ? LayoutUnit() : isRowAxis ?  m_columnPositions[initialPosition] : m_rowPositions[initialPosition];
-    LayoutUnit end = endIsAuto ? (isRowAxis ? logicalWidth() : logicalHeight()) : (isRowAxis ?  m_columnPositions[finalPosition] : m_rowPositions[finalPosition]);
-
     breadth = end - start;
 
     if (startIsAuto)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to