Title: [198753] trunk
- Revision
- 198753
- Author
- za...@apple.com
- Date
- 2016-03-28 11:39:21 -0700 (Mon, 28 Mar 2016)
Log Message
Setup cloned continuation renderer properly.
https://bugs.webkit.org/show_bug.cgi?id=155640
Reviewed by Simon Fraser.
Set the "renderer has outline ancestor" flag on the cloned inline renderer when
we split the original renderer for continuation.
It ensures that when the cloned part of the continuation requests repaint, we properly
invalidate the ancestor outline (if needed).
Source/WebCore:
Test: fast/inline/outline-with-continuation-assert.html
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clone):
LayoutTests:
* fast/inline/outline-with-continuation-assert-expected.txt: Added.
* fast/inline/outline-with-continuation-assert.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (198752 => 198753)
--- trunk/LayoutTests/ChangeLog 2016-03-28 18:21:08 UTC (rev 198752)
+++ trunk/LayoutTests/ChangeLog 2016-03-28 18:39:21 UTC (rev 198753)
@@ -1,3 +1,18 @@
+2016-03-28 Zalan Bujtas <za...@apple.com>
+
+ Setup cloned continuation renderer properly.
+ https://bugs.webkit.org/show_bug.cgi?id=155640
+
+ Reviewed by Simon Fraser.
+
+ Set the "renderer has outline ancestor" flag on the cloned inline renderer when
+ we split the original renderer for continuation.
+ It ensures that when the cloned part of the continuation requests repaint, we properly
+ invalidate the ancestor outline (if needed).
+
+ * fast/inline/outline-with-continuation-assert-expected.txt: Added.
+ * fast/inline/outline-with-continuation-assert.html: Added.
+
2016-03-28 Ryan Haddad <ryanhad...@apple.com>
Marking transitions/cancel-transition.html as flaky on ios-sim-wk2
Added: trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt (0 => 198753)
--- trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt 2016-03-28 18:39:21 UTC (rev 198753)
@@ -0,0 +1,2 @@
+PASS if no assert in Debug.
+a
Added: trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html (0 => 198753)
--- trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html (rev 0)
+++ trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html 2016-03-28 18:39:21 UTC (rev 198753)
@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that inline continuation inherits outline painting properly.</title>
+</head>
+<style>
+div {
+ outline: auto
+}
+</style>
+</head>
+<body>
+PASS if no assert in Debug.
+<div>
+<span><span><span id="foo"></span>a</span></span>
+</div>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ document.execCommand('selectAll');
+ var child = document.createElement('frame');
+ parent = document.getElementById('foo');
+ parent.appendChild(child);
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (198752 => 198753)
--- trunk/Source/WebCore/ChangeLog 2016-03-28 18:21:08 UTC (rev 198752)
+++ trunk/Source/WebCore/ChangeLog 2016-03-28 18:39:21 UTC (rev 198753)
@@ -1,3 +1,20 @@
+2016-03-28 Zalan Bujtas <za...@apple.com>
+
+ Setup cloned continuation renderer properly.
+ https://bugs.webkit.org/show_bug.cgi?id=155640
+
+ Reviewed by Simon Fraser.
+
+ Set the "renderer has outline ancestor" flag on the cloned inline renderer when
+ we split the original renderer for continuation.
+ It ensures that when the cloned part of the continuation requests repaint, we properly
+ invalidate the ancestor outline (if needed).
+
+ Test: fast/inline/outline-with-continuation-assert.html
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clone):
+
2016-03-25 Simon Fraser <simon.fra...@apple.com>
Inspector Memory Timeline sometimes encounters unstoppable rAF drawing
Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (198752 => 198753)
--- trunk/Source/WebCore/rendering/RenderInline.cpp 2016-03-28 18:21:08 UTC (rev 198752)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2016-03-28 18:39:21 UTC (rev 198753)
@@ -416,6 +416,7 @@
RenderPtr<RenderInline> cloneInline = createRenderer<RenderInline>(*element(), style());
cloneInline->initializeStyle();
cloneInline->setFlowThreadState(flowThreadState());
+ cloneInline->setHasOutlineAutoAncestor(hasOutlineAutoAncestor());
return cloneInline;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
