Title: [199721] trunk/Source/WebInspectorUI
- Revision
- 199721
- Author
- commit-qu...@webkit.org
- Date
- 2016-04-19 05:34:33 -0700 (Tue, 19 Apr 2016)
Log Message
REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations view are too large
https://bugs.webkit.org/show_bug.cgi?id=156729
<rdar://problem/25796002>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-04-19
Reviewed by Timothy Hatcher.
* UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
Fix callsite that failed to be updated once percentageString
required 0..1 input instead of 0..100.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (199720 => 199721)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-19 12:22:58 UTC (rev 199720)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-19 12:34:33 UTC (rev 199721)
@@ -1,3 +1,16 @@
+2016-04-19 Joseph Pecoraro <pecor...@apple.com>
+
+ REGRESSION (r199635) Web Inspector: Percentages in Heap Allocations view are too large
+ https://bugs.webkit.org/show_bug.cgi?id=156729
+ <rdar://problem/25796002>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
+ (WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
+ Fix callsite that failed to be updated once percentageString
+ required 0..1 input instead of 0..100.
+
2016-04-18 Timothy Hatcher <timo...@apple.com>
Web Inspector: NavigationSidebarPanel does a lot of style recalc and layout on busy sites
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js (199720 => 199721)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-04-19 12:22:58 UTC (rev 199720)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-04-19 12:34:33 UTC (rev 199721)
@@ -111,10 +111,10 @@
let sizeElement = fragment.appendChild(document.createElement("span"));
sizeElement.classList.add("size");
sizeElement.textContent = Number.bytesToString(size);
- let percent = (size / this._tree._heapSnapshot.totalSize) * 100;
+ let fraction = size / this._tree._heapSnapshot.totalSize;
let percentElement = fragment.appendChild(document.createElement("span"));
percentElement.classList.add("percentage");
- percentElement.textContent = Number.percentageString(percent);
+ percentElement.textContent = Number.percentageString(fraction);
return fragment;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
