Title: [199816] trunk/Source/WebCore
- Revision
- 199816
- Author
- cdu...@apple.com
- Date
- 2016-04-21 08:42:44 -0700 (Thu, 21 Apr 2016)
Log Message
Drop [UsePointersEvenForNonNullableObjectArguments] from DOMURL
https://bugs.webkit.org/show_bug.cgi?id=156797
Reviewed by Youenn Fablet.
* html/DOMURL.cpp:
(WebCore::DOMURL::create):
* html/DOMURL.h:
* html/DOMURL.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199815 => 199816)
--- trunk/Source/WebCore/ChangeLog 2016-04-21 15:12:11 UTC (rev 199815)
+++ trunk/Source/WebCore/ChangeLog 2016-04-21 15:42:44 UTC (rev 199816)
@@ -1,3 +1,15 @@
+2016-04-21 Chris Dumez <cdu...@apple.com>
+
+ Drop [UsePointersEvenForNonNullableObjectArguments] from DOMURL
+ https://bugs.webkit.org/show_bug.cgi?id=156797
+
+ Reviewed by Youenn Fablet.
+
+ * html/DOMURL.cpp:
+ (WebCore::DOMURL::create):
+ * html/DOMURL.h:
+ * html/DOMURL.idl:
+
2016-04-21 Claudio Saavedra <csaave...@igalia.com>
[GTK][EFL] Move non-glib/gtk platform implementations out of platform/gtk
Modified: trunk/Source/WebCore/html/DOMURL.cpp (199815 => 199816)
--- trunk/Source/WebCore/html/DOMURL.cpp 2016-04-21 15:12:11 UTC (rev 199815)
+++ trunk/Source/WebCore/html/DOMURL.cpp 2016-04-21 15:42:44 UTC (rev 199816)
@@ -43,10 +43,9 @@
return adoptRef(*new DOMURL(url, base, ec));
}
-Ref<DOMURL> DOMURL::create(const String& url, const DOMURL* base, ExceptionCode& ec)
+Ref<DOMURL> DOMURL::create(const String& url, const DOMURL& base, ExceptionCode& ec)
{
- ASSERT(base);
- return adoptRef(*new DOMURL(url, *base, ec));
+ return adoptRef(*new DOMURL(url, base, ec));
}
Ref<DOMURL> DOMURL::create(const String& url, ExceptionCode& ec)
Modified: trunk/Source/WebCore/html/DOMURL.h (199815 => 199816)
--- trunk/Source/WebCore/html/DOMURL.h 2016-04-21 15:12:11 UTC (rev 199815)
+++ trunk/Source/WebCore/html/DOMURL.h 2016-04-21 15:42:44 UTC (rev 199816)
@@ -44,7 +44,7 @@
public:
static Ref<DOMURL> create(const String& url, const String& base, ExceptionCode&);
- static Ref<DOMURL> create(const String& url, const DOMURL* base, ExceptionCode&);
+ static Ref<DOMURL> create(const String& url, const DOMURL& base, ExceptionCode&);
static Ref<DOMURL> create(const String& url, ExceptionCode&);
URL href() const { return m_url; }
Modified: trunk/Source/WebCore/html/DOMURL.idl (199815 => 199816)
--- trunk/Source/WebCore/html/DOMURL.idl 2016-04-21 15:12:11 UTC (rev 199815)
+++ trunk/Source/WebCore/html/DOMURL.idl 2016-04-21 15:42:44 UTC (rev 199816)
@@ -30,14 +30,13 @@
Constructor(DOMString url, DOMString base),
Constructor(DOMString url, DOMURL base),
ConstructorRaisesException,
- UsePointersEvenForNonNullableObjectArguments,
JSGenerateToNativeObject,
JSGenerateToJSObject,
InterfaceName=URL,
ImplementationLacksVTable,
ExportMacro=WEBCORE_EXPORT,
] interface DOMURL {
- [CallWith=ScriptExecutionContext] static DOMString? createObjectURL(Blob? blob);
+ [CallWith=ScriptExecutionContext] static DOMString? createObjectURL(Blob? blob); // FIXME: The return value and the parameter should not be nullable.
[CallWith=ScriptExecutionContext] static void revokeObjectURL(DOMString url);
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
