Title: [199876] trunk
Revision
199876
Author
carlo...@webkit.org
Date
2016-04-22 05:49:03 -0700 (Fri, 22 Apr 2016)

Log Message

[GTK] Enable the download attribute support
https://bugs.webkit.org/show_bug.cgi?id=99025

Reviewed by Žan Doberšek.

.:

* Source/cmake/OptionsGTK.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip tests that should pass now.

* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/ChangeLog (199875 => 199876)


--- trunk/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
@@ -1,3 +1,12 @@
+2016-04-22  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Enable the download attribute support
+        https://bugs.webkit.org/show_bug.cgi?id=99025
+
+        Reviewed by Žan Doberšek.
+
+        * Source/cmake/OptionsGTK.cmake:
+
 2016-04-18  Yusuke Suzuki  <utatane....@gmail.com>
 
         [JSCOnly] Implement RunLoop and remove glib dependency

Modified: trunk/LayoutTests/ChangeLog (199875 => 199876)


--- trunk/LayoutTests/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/LayoutTests/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
@@ -1,3 +1,14 @@
+2016-04-22  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Enable the download attribute support
+        https://bugs.webkit.org/show_bug.cgi?id=99025
+
+        Reviewed by Žan Doberšek.
+
+        Unskip tests that should pass now.
+
+        * platform/gtk/TestExpectations:
+
 2016-04-22  Manuel Rego Casasnovas  <r...@igalia.com>
 
         [css-grid] Fix bug with positioned items in vertical writing mode

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (199875 => 199876)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2016-04-22 12:49:03 UTC (rev 199876)
@@ -280,12 +280,6 @@
 webkit.org/b/99024 media/encrypted-media [ Skip ]
 webkit.org/b/99024 fast/events/constructors/media-key-event-constructor.html [ Timeout ]
 
-# Tests that require ENABLE(DOWNLOAD_ATTRIBUTE).
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-nodownload.html [ Pass ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Failure ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Timeout Pass ]
-
 # CSS Filters is disabled
 webkit.org/b/99026 css3/filters [ Skip ]
 webkit.org/b/99026 fast/filter-image/filter-image.html [ Skip ]

Modified: trunk/Source/cmake/OptionsGTK.cmake (199875 => 199876)


--- trunk/Source/cmake/OptionsGTK.cmake	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Source/cmake/OptionsGTK.cmake	2016-04-22 12:49:03 UTC (rev 199876)
@@ -156,6 +156,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE ${ENABLE_FTL_DEFAULT})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE ON)

Modified: trunk/Tools/ChangeLog (199875 => 199876)


--- trunk/Tools/ChangeLog	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Tools/ChangeLog	2016-04-22 12:49:03 UTC (rev 199876)
@@ -1,3 +1,12 @@
+2016-04-22  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [GTK] Enable the download attribute support
+        https://bugs.webkit.org/show_bug.cgi?id=99025
+
+        Reviewed by Žan Doberšek.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2016-04-21  Keith Miller  <keith_mil...@apple.com>
 
         WebScriptObject description swizzler should work in a multi-threaded world

Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (199875 => 199876)


--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-04-22 12:49:03 UTC (rev 199876)
@@ -249,7 +249,7 @@
       define => "ENABLE_DOM4_EVENTS_CONSTRUCTOR", default => (isAppleWebKit() || isGtk() || isEfl()), value => \$dom4EventsConstructor },
 
     { option => "download-attribute", desc => "Toggle Download Attribute support",
-      define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isEfl(), value => \$downloadAttributeSupport },
+      define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => (isEfl() || isGtk()), value => \$downloadAttributeSupport },
 
     { option => "fetch-api", desc => "Toggle Fetch API support",
       define => "ENABLE_FETCH_API", default => 1, value => \$fetchAPISupport },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to