Title: [199947] trunk/Source/WebInspectorUI
- Revision
- 199947
- Author
- mattba...@apple.com
- Date
- 2016-04-22 19:49:40 -0700 (Fri, 22 Apr 2016)
Log Message
Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons
https://bugs.webkit.org/show_bug.cgi?id=156934
Reviewed by Timothy Hatcher.
* UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
(WebInspector.HeapAllocationsTimelineDataGridNode):
Use existing base class helper function to create main title text.
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
Add icon class names to cell, remove icon element.
* UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
Turn on icons for the column.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (199946 => 199947)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-23 02:00:38 UTC (rev 199946)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-23 02:49:40 UTC (rev 199947)
@@ -1,3 +1,20 @@
+2016-04-22 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons
+ https://bugs.webkit.org/show_bug.cgi?id=156934
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
+ (WebInspector.HeapAllocationsTimelineDataGridNode):
+ Use existing base class helper function to create main title text.
+ (WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
+ Add icon class names to cell, remove icon element.
+
+ * UserInterface/Views/HeapAllocationsTimelineView.js:
+ (WebInspector.HeapAllocationsTimelineView):
+ Turn on icons for the column.
+
2016-04-22 Timothy Hatcher <timo...@apple.com>
Change an assert to a warn based on post review feedback.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js (199946 => 199947)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js 2016-04-23 02:00:38 UTC (rev 199946)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js 2016-04-23 02:49:40 UTC (rev 199947)
@@ -33,7 +33,7 @@
this._heapAllocationsView = heapAllocationsView;
this._data = {
- name: WebInspector.TimelineTabContentView.displayNameForRecord(heapAllocationsTimelineRecord),
+ name: this.displayName(),
timestamp: this._record.timestamp - zeroTime,
size: this._record.heapSnapshot.totalSize,
};
@@ -48,9 +48,9 @@
{
switch (columnIdentifier) {
case "name":
+ cell.classList.add(...this.iconClassNames());
+
let fragment = document.createDocumentFragment();
- let iconElement = fragment.appendChild(document.createElement("img"));
- iconElement.classList.add("icon", "heap-snapshot");
let titleElement = fragment.appendChild(document.createElement("span"));
titleElement.textContent = this._data.name;
let goToButton = fragment.appendChild(WebInspector.createGoToArrowButton());
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (199946 => 199947)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-04-23 02:00:38 UTC (rev 199946)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-04-23 02:49:40 UTC (rev 199947)
@@ -37,6 +37,7 @@
name: {
title: WebInspector.UIString("Name"),
width: "150px",
+ icon: true,
},
timestamp: {
title: WebInspector.UIString("Time"),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
