Title: [200101] trunk/Source/_javascript_Core
Revision
200101
Author
mark....@apple.com
Date
2016-04-26 11:35:18 -0700 (Tue, 26 Apr 2016)

Log Message

Changed jsc options title to be more descriptive.
https://bugs.webkit.org/show_bug.cgi?id=157036

Reviewed by Joseph Pecoraro.

Let the title for --dumpOptions be "Modified JSC runtime options:" since it only
dumps overridden options.  The title for --options will remain "All JSC runtime
options:" since it dumps all all options with verbose detail.

* jsc.cpp:
(CommandLine::parseArguments):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200100 => 200101)


--- trunk/Source/_javascript_Core/ChangeLog	2016-04-26 18:27:08 UTC (rev 200100)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-26 18:35:18 UTC (rev 200101)
@@ -1,3 +1,17 @@
+2016-04-26  Mark Lam  <mark....@apple.com>
+
+        Changed jsc options title to be more descriptive.
+        https://bugs.webkit.org/show_bug.cgi?id=157036
+
+        Reviewed by Joseph Pecoraro.
+
+        Let the title for --dumpOptions be "Modified JSC runtime options:" since it only
+        dumps overridden options.  The title for --options will remain "All JSC runtime
+        options:" since it dumps all all options with verbose detail.
+
+        * jsc.cpp:
+        (CommandLine::parseArguments):
+
 2016-04-26  Oliver Hunt  <oli...@apple.com>
 
         Enable separated heap by default on ios

Modified: trunk/Source/_javascript_Core/jsc.cpp (200100 => 200101)


--- trunk/Source/_javascript_Core/jsc.cpp	2016-04-26 18:27:08 UTC (rev 200100)
+++ trunk/Source/_javascript_Core/jsc.cpp	2016-04-26 18:35:18 UTC (rev 200101)
@@ -2210,8 +2210,12 @@
     for (; i < argc; ++i)
         m_arguments.append(argv[i]);
 
-    if (dumpOptionsLevel != JSC::Options::DumpLevel::None)
-        JSC::Options::dumpAllOptions(stderr, dumpOptionsLevel, "All JSC runtime options:");
+    if (dumpOptionsLevel != JSC::Options::DumpLevel::None) {
+        const char* optionsTitle = (dumpOptionsLevel == JSC::Options::DumpLevel::Overridden)
+            ? "Modified JSC runtime options:"
+            : "All JSC runtime options:";
+        JSC::Options::dumpAllOptions(stderr, dumpOptionsLevel, optionsTitle);
+    }
     JSC::Options::ensureOptionsAreCoherent();
     if (needToExit)
         jscExit(EXIT_SUCCESS);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to