Title: [200133] trunk/Source/_javascript_Core
Revision
200133
Author
benja...@webkit.org
Date
2016-04-27 10:58:14 -0700 (Wed, 27 Apr 2016)

Log Message

Follow up for r200113 on 32bit

I forgot to do the 32bit counterpart of r200113.
The test fails on the bots.

Patch by Benjamin Poulain <bpoul...@apple.com> on 2016-04-27

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200132 => 200133)


--- trunk/Source/_javascript_Core/ChangeLog	2016-04-27 17:53:45 UTC (rev 200132)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-27 17:58:14 UTC (rev 200133)
@@ -1,3 +1,13 @@
+2016-04-27  Benjamin Poulain  <bpoul...@apple.com>
+
+        Follow up for r200113 on 32bit
+
+        I forgot to do the 32bit counterpart of r200113.
+        The test fails on the bots.
+
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        (JSC::DFG::SpeculativeJIT::compile):
+
 2016-04-27  Alberto Garcia  <be...@igalia.com>
 
         [GTK] Fails to build randomly when generating LLIntDesiredOffsets.h

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (200132 => 200133)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2016-04-27 17:53:45 UTC (rev 200132)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2016-04-27 17:58:14 UTC (rev 200133)
@@ -2428,12 +2428,12 @@
             GPRReg resultTagGPR = resultTag.gpr();
             GPRReg resultPayloadGPR = resultPayload.gpr();
 
+            speculationCheck(OutOfBounds, JSValueRegs(), node,
+                m_jit.branch32(MacroAssembler::LessThan, indexGPR, MacroAssembler::TrustedImm32(0)));
+
             use(node->child1());
             index.use();
 
-            speculationCheck(OutOfBounds, JSValueRegs(), node,
-                m_jit.branch32(MacroAssembler::LessThan, indexGPR, MacroAssembler::TrustedImm32(0)));
-
             m_jit.move(MacroAssembler::TrustedImm32(JSValue::UndefinedTag), resultTagGPR);
             m_jit.move(MacroAssembler::TrustedImm32(0), resultPayloadGPR);
             jsValueResult(resultTagGPR, resultPayloadGPR, node, UseChildrenCalledExplicitly);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to