Title: [200719] trunk/Source/WebInspectorUI
- Revision
- 200719
- Author
- commit-qu...@webkit.org
- Date
- 2016-05-11 17:49:44 -0700 (Wed, 11 May 2016)
Log Message
Web Inspector: Console unread indicators should be cleared however the console clears
https://bugs.webkit.org/show_bug.cgi?id=157594
Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-05-11
Reviewed by Timothy Hatcher.
* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._logCleared):
(WebInspector.LogContentView.prototype._clearLog):
Move code that clears unread indicators from clearLog to logCleared
to handle all possible clear cases.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200718 => 200719)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 00:47:07 UTC (rev 200718)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-12 00:49:44 UTC (rev 200719)
@@ -1,3 +1,16 @@
+2016-05-11 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Console unread indicators should be cleared however the console clears
+ https://bugs.webkit.org/show_bug.cgi?id=157594
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/LogContentView.js:
+ (WebInspector.LogContentView.prototype._logCleared):
+ (WebInspector.LogContentView.prototype._clearLog):
+ Move code that clears unread indicators from clearLog to logCleared
+ to handle all possible clear cases.
+
2016-05-11 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: Contents of Duration column are covered by always on (legacy) scroll bars
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (200718 => 200719)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2016-05-12 00:47:07 UTC (rev 200718)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2016-05-12 00:49:44 UTC (rev 200719)
@@ -167,8 +167,6 @@
console.assert(messageView.element instanceof Element);
this._filterMessageElements([messageView.element]);
}
-
-
}
get supportsSearch()
@@ -633,6 +631,9 @@
_logCleared(event)
{
+ for (let item of this._scopeBar.items)
+ item.element.classList.remove("unread");
+
this._logViewController.clear();
this._nestingLevel = 0;
@@ -653,9 +654,6 @@
_clearLog()
{
- for (var item of this._scopeBar.items)
- item.element.classList.remove("unread");
-
WebInspector.logManager.requestClearMessages();
}
@@ -995,4 +993,4 @@
WebInspector.LogContentView.SelectedStyleClassName = "selected";
WebInspector.LogContentView.SearchInProgressStyleClassName = "search-in-progress";
WebInspector.LogContentView.FilteredOutBySearchStyleClassName = "filtered-out-by-search";
-WebInspector.LogContentView.HighlightedStyleClassName = "highlighted";
\ No newline at end of file
+WebInspector.LogContentView.HighlightedStyleClassName = "highlighted";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
