Title: [200737] trunk/Source/_javascript_Core
Revision
200737
Author
commit-qu...@webkit.org
Date
2016-05-11 19:13:51 -0700 (Wed, 11 May 2016)

Log Message

Web Inspector: `this` in Scope Chain Sidebar does not have preview, looks poor
https://bugs.webkit.org/show_bug.cgi?id=157602

Patch by Joseph Pecoraro <pecor...@apple.com> on 2016-05-11
Reviewed by Timothy Hatcher.

* inspector/InjectedScriptSource.js:
(InjectedScript.CallFrameProxy):
Include a preview when creating the RemoteObject for `this`.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200736 => 200737)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-12 02:09:59 UTC (rev 200736)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-12 02:13:51 UTC (rev 200737)
@@ -1,3 +1,14 @@
+2016-05-11  Joseph Pecoraro  <pecor...@apple.com>
+
+        Web Inspector: `this` in Scope Chain Sidebar does not have preview, looks poor
+        https://bugs.webkit.org/show_bug.cgi?id=157602
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InjectedScriptSource.js:
+        (InjectedScript.CallFrameProxy):
+        Include a preview when creating the RemoteObject for `this`.
+
 2016-05-11  Keith Miller  <keith_mil...@apple.com>
 
         Unreviewed, correct the title of the ChangeLog for r200667.

Modified: trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js (200736 => 200737)


--- trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js	2016-05-12 02:09:59 UTC (rev 200736)
+++ trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js	2016-05-12 02:13:51 UTC (rev 200737)
@@ -1298,7 +1298,7 @@
     this.functionName = callFrame.functionName;
     this.location = {scriptId: String(callFrame.sourceID), lineNumber: callFrame.line, columnNumber: callFrame.column};
     this.scopeChain = this._wrapScopeChain(callFrame);
-    this.this = injectedScript._wrapObject(callFrame.thisObject, "backtrace");
+    this.this = injectedScript._wrapObject(callFrame.thisObject, "backtrace", false, true);
 }
 
 InjectedScript.CallFrameProxy.prototype = {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to