Title: [200748] branches/safari-601.1.46-branch

Diff

Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (200747 => 200748)


--- branches/safari-601.1.46-branch/LayoutTests/ChangeLog	2016-05-12 09:03:19 UTC (rev 200747)
+++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog	2016-05-12 09:11:50 UTC (rev 200748)
@@ -1,3 +1,17 @@
+2016-05-12  Matthew Hanson  <matthew_han...@apple.com>
+
+        Merge r190820. rdar://problem/26228881
+
+    2015-10-09  Simon Fraser  <simon.fra...@apple.com>
+
+            Garbage texture data with composited table row
+            https://bugs.webkit.org/show_bug.cgi?id=148984
+
+            Reviewed by Zalan Bujtas.
+
+            * compositing/contents-opaque/table-parts-expected.txt: Added.
+            * compositing/contents-opaque/table-parts.html: Added.
+
 2016-04-22  Matthew Hanson  <matthew_han...@apple.com>
 
         Merge r199881. rdar://problem/25879593

Added: branches/safari-601.1.46-branch/LayoutTests/compositing/contents-opaque/table-parts-expected.txt (0 => 200748)


--- branches/safari-601.1.46-branch/LayoutTests/compositing/contents-opaque/table-parts-expected.txt	                        (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/compositing/contents-opaque/table-parts-expected.txt	2016-05-12 09:11:50 UTC (rev 200748)
@@ -0,0 +1,25 @@
+Table cell
+Table cell
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+    (GraphicsLayer
+      (bounds 800.00 600.00)
+      (contentsOpaque 1)
+      (children 2
+        (GraphicsLayer
+          (position 28.00 20.00)
+          (bounds 252.00 102.00)
+          (drawsContent 1)
+        )
+        (GraphicsLayer
+          (position 28.00 142.00)
+          (bounds 252.00 102.00)
+          (drawsContent 1)
+        )
+      )
+    )
+  )
+)
+

Added: branches/safari-601.1.46-branch/LayoutTests/compositing/contents-opaque/table-parts.html (0 => 200748)


--- branches/safari-601.1.46-branch/LayoutTests/compositing/contents-opaque/table-parts.html	                        (rev 0)
+++ branches/safari-601.1.46-branch/LayoutTests/compositing/contents-opaque/table-parts.html	2016-05-12 09:11:50 UTC (rev 200748)
@@ -0,0 +1,55 @@
+<!DOCTYPE html>
+
+<html>
+<head>
+    <style>
+
+        table {
+            border-collapse: collapse;
+            margin: 20px;
+        }
+
+        tr {
+            background-color: silver;
+            border-right: 100px solid gray;
+        }
+        
+        td {
+            width: 200px;
+            height: 100px;
+        }
+        
+        .composited {
+            -webkit-transform: translateZ(0);
+        }
+        
+        td.composited {
+            background-color: silver;
+        }
+    </style>
+    <script>
+        if (window.testRunner)
+            testRunner.dumpAsText();
+
+        function doTest() {
+            if (window.testRunner && window.internals)
+                document.getElementById('layertree').innerText = window.internals.layerTreeAsText(document);
+        }
+        window.addEventListener('load', doTest, false);
+    </script>
+</head>
+<body>
+<table>
+    <tr class="composited">
+        <td>Table cell</td>
+    </tr>
+</table>
+
+<table>
+    <tr>
+        <td class="composited">Table cell</td>
+    </tr>
+</table>
+<pre id="layertree"></pre> 
+</body>
+</html>

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (200747 => 200748)


--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2016-05-12 09:03:19 UTC (rev 200747)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2016-05-12 09:11:50 UTC (rev 200748)
@@ -1,3 +1,22 @@
+2016-05-12  Matthew Hanson  <matthew_han...@apple.com>
+
+        Merge r190820. rdar://problem/26228881
+
+    2015-10-09  Simon Fraser  <simon.fra...@apple.com>
+
+            Garbage texture data with composited table row
+            https://bugs.webkit.org/show_bug.cgi?id=148984
+
+            Reviewed by Zalan Bujtas.
+
+            Don't pretend to know if the layer for a table header, section or cell is
+            opaque, since table painting is special.
+
+            Test: compositing/contents-opaque/table-parts.html
+
+            * rendering/RenderLayer.cpp:
+            (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
+
 2016-04-22  Matthew Hanson  <matthew_han...@apple.com>
 
         Merge r199881. rdar://problem/25879593

Modified: branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderLayer.cpp (200747 => 200748)


--- branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderLayer.cpp	2016-05-12 09:03:19 UTC (rev 200747)
+++ branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderLayer.cpp	2016-05-12 09:11:50 UTC (rev 200748)
@@ -6132,6 +6132,10 @@
     if (m_zOrderListsDirty || m_normalFlowListDirty)
         return false;
 
+    // Table painting is special; a table paints its sections.
+    if (renderer().isTablePart())
+        return false;
+
     // FIXME: We currently only check the immediate renderer,
     // which will miss many cases.
     if (renderer().backgroundIsKnownToBeOpaqueInRect(localRect))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to