Title: [200938] trunk/Source/WebCore
- Revision
- 200938
- Author
- fred.w...@free.fr
- Date
- 2016-05-15 23:23:36 -0700 (Sun, 15 May 2016)
Log Message
Small removal of useless code for MathML token elements
https://bugs.webkit.org/show_bug.cgi?id=157568
Patch by Frederic Wang <fw...@igalia.com> on 2016-05-15
Reviewed by Darin Adler.
We remove two pieces of code for MathML token elements with unclear purposes and that do not
have any effect on math rendering.
No new tests, behavior is unchanged.
* css/mathml.css:
(mtext): Deleted. This was probably a hack that is no longer needed with the latest math font
ascent/descent management.
* mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): Deleted. Removing this does not break
the mentioned test.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (200937 => 200938)
--- trunk/Source/WebCore/ChangeLog 2016-05-16 00:47:26 UTC (rev 200937)
+++ trunk/Source/WebCore/ChangeLog 2016-05-16 06:23:36 UTC (rev 200938)
@@ -1,3 +1,22 @@
+2016-05-15 Frederic Wang <fw...@igalia.com>
+
+ Small removal of useless code for MathML token elements
+ https://bugs.webkit.org/show_bug.cgi?id=157568
+
+ Reviewed by Darin Adler.
+
+ We remove two pieces of code for MathML token elements with unclear purposes and that do not
+ have any effect on math rendering.
+
+ No new tests, behavior is unchanged.
+
+ * css/mathml.css:
+ (mtext): Deleted. This was probably a hack that is no longer needed with the latest math font
+ ascent/descent management.
+ * mathml/MathMLTextElement.cpp:
+ (WebCore::MathMLTextElement::createElementRenderer): Deleted. Removing this does not break
+ the mentioned test.
+
2016-05-15 Chris Dumez <cdu...@apple.com>
Use more references in JS wrappers related code
Modified: trunk/Source/WebCore/css/mathml.css (200937 => 200938)
--- trunk/Source/WebCore/css/mathml.css 2016-05-16 00:47:26 UTC (rev 200937)
+++ trunk/Source/WebCore/css/mathml.css 2016-05-16 06:23:36 UTC (rev 200938)
@@ -93,9 +93,6 @@
/* FIXME: Should we reset more CSS properties (http://webkit.org/b/156839)? */
}
-mtext {
- line-height: 1.0;
-}
math {
display: -webkit-inline-flex !important;
Modified: trunk/Source/WebCore/mathml/MathMLTextElement.cpp (200937 => 200938)
--- trunk/Source/WebCore/mathml/MathMLTextElement.cpp 2016-05-16 00:47:26 UTC (rev 200937)
+++ trunk/Source/WebCore/mathml/MathMLTextElement.cpp 2016-05-16 06:23:36 UTC (rev 200938)
@@ -86,10 +86,6 @@
ASSERT(hasTagName(MathMLNames::miTag) || hasTagName(MathMLNames::mnTag) || hasTagName(MathMLNames::msTag) || hasTagName(MathMLNames::mtextTag));
- // FIXME: why do we have to set the alignment here ? It seems needed to make the
- // style-changed.htmt test to pass, since mathml renders expect Stretch as default.
- style.setAlignItemsPosition(ItemPositionStretch);
-
return createRenderer<RenderMathMLToken>(*this, WTFMove(style));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
